-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Type] Refactor Vec #4296
Merged
Merged
[Type] Refactor Vec #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: breaking
Change possibly inducing a compilation error
pr: status to review
To notify reviewers to review this pull-request
pr: clean
Cleaning the code
labels
Nov 16, 2023
[ci-build][with-all-tests][force-full-build] |
alxbilger
reviewed
Nov 29, 2023
fredroy
force-pushed
the
vec_as_array
branch
2 times, most recently
from
December 5, 2023 13:08
a639cba
to
17f92cf
Compare
alxbilger
approved these changes
Dec 6, 2023
alxbilger
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Dec 6, 2023
fredroy
force-pushed
the
vec_as_array
branch
2 times, most recently
from
December 10, 2023 23:47
c7a6a9f
to
8c01993
Compare
fredroy
force-pushed
the
vec_as_array
branch
from
December 12, 2023 05:17
8c01993
to
1e90c52
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: breaking
Change possibly inducing a compilation error
pr: clean
Cleaning the code
pr: status ready
Approved a pull-request, ready to be squashed
STC#16
Tasks for STC#16 coding sprint
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the task #4217
This PR removes the inheritance on type::fixed_array and use std::array to store the elements.
No performance change noticed on few scenes (caduceus, TorusFall, beamadapter scene) on Windows/msvc, linux/gcc and macos/clang.
Benches: (Ubuntu, gcc)
Unit:
https://ethercalc.net/jt9xe3yadxug
Mostly the same, except:
EDIT: and apparently is mitigated by using LTO
Scenes :
caduceus:
10000 iterations done in 6.61867 s ( 1510.88 FPS)
10000 iterations done in 6.59469 s ( 1516.37 FPS)
TorusFall:
5000 iterations done in 15.6086 s ( 320.336 FPS)
5000 iterations done in 15.6149 s ( 320.207 FPS)
3instruments_collis
5000 iterations done in 30.5179 s ( 163.838 FPS)
5000 iterations done in 30.2582 s ( 165.244 FPS)
With LTO:
caduceus:
10000 iterations done in 6.55136 s ( 1526.4 FPS)
10000 iterations done in 6.49977 s ( 1538.52 FPS)
TorusFall:
5000 iterations done in 15.4835 s ( 322.925 FPS)
5000 iterations done in 14.8696 s ( 336.256 FPS)
3instruments_collis
5000 iterations done in 30.0172 s ( 166.571 FPS)
5000 iterations done in 29.9373 s ( 167.016 FPS)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if