Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Type] Refactor Vec #4296

Merged
merged 12 commits into from
Dec 12, 2023
Merged

[Type] Refactor Vec #4296

merged 12 commits into from
Dec 12, 2023

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Nov 16, 2023

Part of the task #4217

This PR removes the inheritance on type::fixed_array and use std::array to store the elements.

No performance change noticed on few scenes (caduceus, TorusFall, beamadapter scene) on Windows/msvc, linux/gcc and macos/clang.


Benches: (Ubuntu, gcc)
Unit:
https://ethercalc.net/jt9xe3yadxug

Mostly the same, except:

Scenes :
caduceus:

  • master: 10000 iterations done in 6.61867 s ( 1510.88 FPS)
  • pr: 10000 iterations done in 6.59469 s ( 1516.37 FPS)

TorusFall:

  • master: 5000 iterations done in 15.6086 s ( 320.336 FPS)
  • pr: 5000 iterations done in 15.6149 s ( 320.207 FPS)

3instruments_collis

  • master: 5000 iterations done in 30.5179 s ( 163.838 FPS)
  • pr: 5000 iterations done in 30.2582 s ( 165.244 FPS)

With LTO:
caduceus:

  • master: 10000 iterations done in 6.55136 s ( 1526.4 FPS)
  • pr: 10000 iterations done in 6.49977 s ( 1538.52 FPS)

TorusFall:

  • master: 5000 iterations done in 15.4835 s ( 322.925 FPS)
  • pr: 5000 iterations done in 14.8696 s ( 336.256 FPS)

3instruments_collis

  • master: 5000 iterations done in 30.0172 s ( 166.571 FPS)
  • pr: 5000 iterations done in 29.9373 s ( 167.016 FPS)

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: breaking Change possibly inducing a compilation error pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Nov 16, 2023
@hugtalbot hugtalbot added the STC#16 Tasks for STC#16 coding sprint label Nov 17, 2023
@fredroy
Copy link
Contributor Author

fredroy commented Nov 22, 2023

[ci-build][with-all-tests][force-full-build]

@hugtalbot hugtalbot added this to the v24.06 milestone Nov 22, 2023
@fredroy fredroy force-pushed the vec_as_array branch 2 times, most recently from a639cba to 17f92cf Compare December 5, 2023 13:08
@alxbilger alxbilger added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 6, 2023
@fredroy fredroy force-pushed the vec_as_array branch 2 times, most recently from c7a6a9f to 8c01993 Compare December 10, 2023 23:47
@epernod epernod merged commit 4a40054 into sofa-framework:master Dec 12, 2023
9 of 10 checks passed
@fredroy fredroy deleted the vec_as_array branch December 19, 2023 07:32
@fredroy fredroy mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed STC#16 Tasks for STC#16 coding sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants