Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] ColorMap uses RGBAColor #4270

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Oct 30, 2023

Based on

Part of the task to use std container and also just it felt dumb that ColorMap was not using the standard RGBAColor class
Mostly breaking because people needed to convert the result of ColorMap::eval() to RGBAColor


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: breaking Change possibly inducing a compilation error pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 30, 2023
@fredroy
Copy link
Contributor Author

fredroy commented Oct 30, 2023

[ci-build][with-all-tests]

@fredroy fredroy force-pushed the colormap_use_rgbcolor branch from eba677c to 9b438e7 Compare November 9, 2023 01:10
@fredroy fredroy mentioned this pull request Nov 16, 2023
@hugtalbot hugtalbot added this to the v24.06 milestone Nov 22, 2023
@fredroy fredroy force-pushed the colormap_use_rgbcolor branch from 9b438e7 to acadc34 Compare December 5, 2023 07:18
@bakpaul bakpaul merged commit a404343 into sofa-framework:master Dec 5, 2023
10 checks passed
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants