Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helper] Fix Colormap when using HSV to RGB #4408

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Dec 26, 2023

it was not noticed in #4270 that the two version of RGB from HSV was different on Hue value
(one is normalized [0...1], the other in RGBAColor is not and is in degree [0...360])

for those interested : http://wiki.gis.com/wiki/index.php/HSV_Color_Space

FYI while debugging, an issue in TetraFEMForcefield has been found #4407


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Dec 26, 2023
@fredroy fredroy changed the title [Helper] Fix Colormap when using HSB to RGB [Helper] Fix Colormap when using HSV to RGB Dec 26, 2023
@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 26, 2023
@epernod epernod merged commit ed5b29c into sofa-framework:master Dec 27, 2023
22 checks passed
@fredroy fredroy deleted the fix_colormap_hsv branch January 7, 2024 23:39
@hugtalbot hugtalbot added pr: backport todo This PR will be backported into the release preceeding its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jan 10, 2024
@hugtalbot hugtalbot added this to the v24.06 milestone Jan 10, 2024
hugtalbot pushed a commit to hugtalbot/sofa that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants