[All] Changed message for scene check #4324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork#4293) Fix linking with LTO on macos
* [LinearSolver.Direct] Remove CSparse based solvers * Remove csparse extlib * Fetchable CSparseSolvers plugin * Remove references of SparseLUSolver * Remove references to SparseCholeskySolver * Remove csparse * Try to fix on Linux * Update the compat * [LinearSolver.Direct] Remove CSparse based solvers * Fix direct solver
Co-authored-by: erik pernod <erik.pernod@gmail.com>
* Add cmake module for QGLViewer * Support library name for apt packages * Fix qglviewer cmake finder module to first seach for a config cmake file. * Update cmake/Modules/FindQGLViewer.cmake Co-authored-by: Hugo <hugo.talbot@sofa-framework.org> --------- Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com> Co-authored-by: Hugo <hugo.talbot@sofa-framework.org>
* Remove unlogical use of visitor * Delete unused methods
…rk#4317) * [LinearSystem] Speedup computation of Jacobian matrices in case both mstates are the same * minor reformat to align calls to computeJacobiansFrom
…sofa-framework#4319) * FIX compilation SofaCUDA along with SparseGrid with Cuda12 * Use a multiplication instead
…amework#4310) * Add message to make it more clear * slight modifications to be even more clear and add an error the dependency cannot be met
…ramework#4320) remove ref to non-existent sofasimu Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
…onent is in component change
fredroy
added
enhancement
|
[ci-build][with-all-tests] |
|
Is this the only commit to focus on ? 7bf84de |
|
No there are two, I've modified my first message, this one and the next one, but the real improvement is in the one you pointed exactly ! |
4 tasks
hugtalbot
removed
the
pr: status to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on
The map
uncreatableComponentsis used both by the factory when the object could not be created and by the alias check. So, cometimes, mif you used an alias of a component that has also been moved, a non sens was displayed.This pr divide this map in two :
uncreatableComponentsandmovedComponentsand only use theuncreatableComponentsin scene check and also display the original message.