[Constraint] Make name of constraints more explicit #4302

bakpaul · 2023-11-17T10:44:33Z

This PR is a first step for the issue #3952.

I modified the names of the constraints following the rule that we agreed upon. Still need to change spring force-fields that can behave as penalties.

The changes where straight, not more though than adding the type into the name was done. If any name doesn't fit your standard, feel free to suggest any changes.

This PR also add a componentRenamed mechanism that creates an alias automatically for renamed objects.

TODO:

Edit Sofa/framework/Helper/src/sofa/helper/ComponentChange.cpp
- Add a API in ComponentChange.cpp for Renamed component (avoiding to add an alias manually in the class)
Move the C++ alias in the old header
Change name of projective constraints strating by ProjectOn

bakpaul · 2023-11-21T16:20:57Z

[ci-build][with-all-tests]

bakpaul · 2023-11-21T16:22:30Z

I am just not sure about the alias compatibility. It is for scene launching, but nothing guaranty that those aliases will one day be removed. Maybe the factory lacks a method addDeprecationAlias (or I am not aware of this) ?

alxbilger

You need to edit Sofa/framework/Helper/src/sofa/helper/ComponentChange.cpp

hugtalbot · 2023-11-22T10:15:45Z

Move the C++ alias in the old header (with the include of the new .h before)

Doc for lifecycle: https://www.sofa-framework.org/community/doc/contributing-to-sofa/lifecycle-mechanisms/#renaming-a-component

Maybe thinking about adding a API in ComponentChange.cpp for Renamed component (avoiding to add an alias manually in the class)

…ork#4293) Fix linking with LTO on macos

* [LinearSolver.Direct] Remove CSparse based solvers * Remove csparse extlib * Fetchable CSparseSolvers plugin * Remove references of SparseLUSolver * Remove references to SparseCholeskySolver * Remove csparse * Try to fix on Linux * Update the compat * [LinearSolver.Direct] Remove CSparse based solvers * Fix direct solver

Co-authored-by: erik pernod <erik.pernod@gmail.com>

* Add cmake module for QGLViewer * Support library name for apt packages * Fix qglviewer cmake finder module to first seach for a config cmake file. * Update cmake/Modules/FindQGLViewer.cmake Co-authored-by: Hugo <hugo.talbot@sofa-framework.org> --------- Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com> Co-authored-by: Hugo <hugo.talbot@sofa-framework.org>

…work#4307)

* Remove unlogical use of visitor * Delete unused methods

bakpaul · 2023-11-29T16:09:39Z

[ci-build][with-all-tests]

alxbilger

Almost good to go. Keep in mind that the documentation website will need to be updated accordingly.

alxbilger · 2023-12-11T07:59:44Z

...rangian/Model/src/sofa/component/constraint/lagrangian/model/SlidingLagrangianConstraint.cpp

@@ -32,10 +32,10 @@ namespace sofa::component::constraint::lagrangian::model
 using namespace sofa::defaulttype;
 using namespace sofa::helper;

-int SlidingConstraintClass = core::RegisterObject("TODO-SlidingConstraint")
-        .add< SlidingConstraint<Vec3Types> >(true);
+int SlidingLagrangianConstraintClass = core::RegisterObject("TODO-SlidingLagrangianConstraint")


I am not really happy with this description...

Yes me neither, but in fact this is not the only component and it is not really in the scope of this pr...

applications/plugins/SofaCarving/examples/CarvingTool.scn

bakpaul · 2023-12-18T10:39:44Z

[ci-build][with-all-tests]

…onent is in component change

bakpaul · 2023-12-18T16:36:13Z

Finally I needed the changed introduced in the (now closed) PR #4324 to finalize the automatic alias creation mechanism. Now CI should not be crying anymore.

bakpaul · 2023-12-18T16:40:13Z

[ci-build][with-all-tests]

) * Added projective and lagrangian suffix * Reported changes to Cuda plugin * Modify rest of the code to avoid warning from compatibility layer * Add compatibility layer for deprecated header in CUDA * add alias for compatibility layer in scene construction * Report name modification to all scenes * Revert Compat modification... * [LinearAlgera, Core] Fix linking with LTO on MacOS/Clang (sofa-framework#4293) Fix linking with LTO on macos * [LinearSolver] Remove CSparse-based linear solvers (sofa-framework#4258) * [LinearSolver.Direct] Remove CSparse based solvers * Remove csparse extlib * Fetchable CSparseSolvers plugin * Remove references of SparseLUSolver * Remove references to SparseCholeskySolver * Remove csparse * Try to fix on Linux * Update the compat * [LinearSolver.Direct] Remove CSparse based solvers * Fix direct solver * [GUI.Qt] Minor single-line cleaning (sofa-framework#4308) Co-authored-by: erik pernod <erik.pernod@gmail.com> * [Sofa.GUI.Qt] Add cmake module for QGLViewer (sofa-framework#4290) * Add cmake module for QGLViewer * Support library name for apt packages * Fix qglviewer cmake finder module to first seach for a config cmake file. * Update cmake/Modules/FindQGLViewer.cmake Co-authored-by: Hugo <hugo.talbot@sofa-framework.org> --------- Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com> Co-authored-by: Hugo <hugo.talbot@sofa-framework.org> * [MultiThreading] Avoid Static Initialization Order Fiasco (sofa-framework#4307) * [Core] Minor clean of DefaultAnimationLoop (sofa-framework#4314) * Remove unlogical use of visitor * Delete unused methods * [LinearSystem] Speedup computation of Jacobian matrices (sofa-framework#4317) * [LinearSystem] Speedup computation of Jacobian matrices in case both mstates are the same * minor reformat to align calls to computeJacobiansFrom * [SofaCUDA] FIX compilation SofaCUDA along with SparseGrid with Cuda12 (sofa-framework#4319) * FIX compilation SofaCUDA along with SparseGrid with Cuda12 * Use a multiplication instead * [Common] Add message to make the fetch mechanism less hidden (sofa-framework#4310) * Add message to make it more clear * slight modifications to be even more clear and add an error the dependency cannot be met * [Collections] Remove reference to non-existing SofaSimulation (sofa-framework#4320) remove ref to non-existent sofasimu Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com> * Remove repeating preffix from projective constraints * Moved alias to original header * Changed deprecation date * add component change entry * Change name following discussion with Hugo * Change remaining scene with FixedConstraint * remove last occurences in py files * Changed the message display of sceneCheckUsingAlias when aliased component is in component change * Fix factory * Add alias creation when object in componentRenamed in factory * Remove precedently added aliases --------- Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com> Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com> Co-authored-by: erik pernod <erik.pernod@gmail.com> Co-authored-by: Olivier Roussel <olivier.roussel@inria.fr> Co-authored-by: Hugo <hugo.talbot@sofa-framework.org>

Added projective and lagrangian suffix

a50701b

bakpaul added refactoring Refactor code STC#16 Tasks for STC#16 coding sprint labels Nov 17, 2023

bakpaul added this to the v23.12 milestone Nov 17, 2023

bakpaul added topic for next dev-meeting PR to be discussed in sofa-dev meeting pr: status to review To notify reviewers to review this pull-request labels Nov 20, 2023

bakpaul added 2 commits November 21, 2023 16:21

Reported changes to Cuda plugin

6502243

Modify rest of the code to avoid warning from compatibility layer

5252432

bakpaul added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Nov 21, 2023

bakpaul added 3 commits November 21, 2023 17:17

Add compatibility layer for deprecated header in CUDA

c315181

add alias for compatibility layer in scene construction

39b00dd

Report name modification to all scenes

42fe9f6

bakpaul added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Nov 21, 2023

Revert Compat modification...

b9d94ea

alxbilger reviewed Nov 22, 2023

View reviewed changes

hugtalbot modified the milestones: v23.12, v24.06 Nov 22, 2023

fredroy added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Nov 29, 2023

fredroy and others added 6 commits November 29, 2023 14:49

[LinearAlgera, Core] Fix linking with LTO on MacOS/Clang (sofa-framew…

d689871

…ork#4293) Fix linking with LTO on macos

[GUI.Qt] Minor single-line cleaning (sofa-framework#4308)

af57258

Co-authored-by: erik pernod <erik.pernod@gmail.com>

[MultiThreading] Avoid Static Initialization Order Fiasco (sofa-frame…

620bc51

…work#4307)

[Core] Minor clean of DefaultAnimationLoop (sofa-framework#4314)

7f4fdef

* Remove unlogical use of visitor * Delete unused methods

bakpaul mentioned this pull request Nov 29, 2023

[All] Changed message for scene check #4324

Closed

Merge branch 'master' into change_naming_of_constraints

82196ac

alxbilger added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Dec 6, 2023

alxbilger requested changes Dec 11, 2023

View reviewed changes

bakpaul added 2 commits December 11, 2023 09:31

Merge branch 'master' into change_naming_of_constraints

ab74bab

Change name following discussion with Hugo

78a1cb3

bakpaul added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Dec 11, 2023

bakpaul and others added 4 commits December 11, 2023 17:36

Change remaining scene with FixedConstraint

6aa6ee1

remove last occurences in py files

43b6294

Merge branch 'master' into change_naming_of_constraints

2e08675

Merge branch 'master' into change_naming_of_constraints

736602f

bakpaul and others added 4 commits December 18, 2023 16:51

Changed the message display of sceneCheckUsingAlias when aliased comp…

e4b68d6

…onent is in component change

Fix factory

181eb9a

Add alias creation when object in componentRenamed in factory

d0dc32e

Remove precedently added aliases

9f8fe2e

alxbilger added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 20, 2023

bakpaul added 2 commits December 20, 2023 09:49

Merge branch 'master' into change_naming_of_constraints

e7a685c

Merge branch 'master' into change_naming_of_constraints

7d1fd86

hugtalbot merged commit 026a501 into sofa-framework:master Dec 20, 2023
10 checks passed

hugtalbot mentioned this pull request Jun 5, 2024

[examples] Rename FixedConstraint example #4764

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Constraint] Make name of constraints more explicit #4302

[Constraint] Make name of constraints more explicit #4302

bakpaul commented Nov 17, 2023 •

edited

Loading

bakpaul commented Nov 21, 2023

bakpaul commented Nov 21, 2023

alxbilger left a comment

hugtalbot commented Nov 22, 2023 •

edited

Loading

bakpaul commented Nov 29, 2023

alxbilger left a comment

alxbilger Dec 11, 2023

bakpaul Dec 12, 2023

bakpaul commented Dec 18, 2023

bakpaul commented Dec 18, 2023

bakpaul commented Dec 18, 2023

[Constraint] Make name of constraints more explicit #4302

[Constraint] Make name of constraints more explicit #4302

Conversation

bakpaul commented Nov 17, 2023 • edited Loading

bakpaul commented Nov 21, 2023

bakpaul commented Nov 21, 2023

alxbilger left a comment

Choose a reason for hiding this comment

hugtalbot commented Nov 22, 2023 • edited Loading

bakpaul commented Nov 29, 2023

alxbilger left a comment

Choose a reason for hiding this comment

alxbilger Dec 11, 2023

Choose a reason for hiding this comment

bakpaul Dec 12, 2023

Choose a reason for hiding this comment

bakpaul commented Dec 18, 2023

bakpaul commented Dec 18, 2023

bakpaul commented Dec 18, 2023

bakpaul commented Nov 17, 2023 •

edited

Loading

hugtalbot commented Nov 22, 2023 •

edited

Loading