[Simulation.Core] Deprecate LocalStorage feature #4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: status to review
fredroy
force-pushed
the
remove_core_localstorage
branch
from
1dde1d9 to
0cc78ad
Compare
|
Well you did the deprecation job. But you're right, this could disappear totally... |
bakpaul
approved these changes
Dec 1, 2023
alxbilger
approved these changes
Dec 6, 2023
alxbilger
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates LocalStorage and its (only) implementation CactusLocalStorage.
It seems it was planned for an eventual parallelization of the visitor traversal. Since then, it is not really relevant anymore (link, etc)
Present since the beginning (16 years ago!) but it seems it was never used,
as the only implementation of LocalStorage (CactusLocalStorage) is never instanced anywhere.
IMO we could even directly remove it as it is 99,99...9% sure nobody uses it.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if