-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Simulation.Core] Remove usage of ill-used nodeData in MechanicalGetNonDiagonalMassesCountVisitor and MechanicalVDotVisitor #4328
[Simulation.Core] Remove usage of ill-used nodeData in MechanicalGetNonDiagonalMassesCountVisitor and MechanicalVDotVisitor #4328
Conversation
[ci-build][with-all-tests] |
09d03e9
to
b882c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the counter is SReal only because of the use of nodeData
. If you don't use it, I don't see any reason to switch to an integer.
To keep the API "non-breaking" 🙊 but I can make it an integer if we dont care ✌️ |
Since this visitor is rather recent, and used at only one place. We can consider convert the SReal to an integer even if it's breaking |
bb55ac1
to
64634c7
Compare
...tion/Core/src/sofa/simulation/mechanicalvisitor/MechanicalGetNonDiagonalMassesCountVisitor.h
Outdated
Show resolved
Hide resolved
64634c7
to
f046295
Compare
First task of removing(deprecating) the usage of nodeData (noticed in #4327)
Those two visitors are using the pointer nodeData for local computations so It was changed to local (weak) stored pointers.
Not fan of pointers but it does not break API. (a SReal to count is weird btw)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if