[ALL] FIX all scenes failures 17.12 #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those file have been merge by mistake some time ago but they have no meaning in the current Sofa version. So I remove them.
I know it is deprecated but...well it is better to update it so this minimize the amount of work in case someone want to use it in the future.
…verbose is true Why: serr is generating a lot of warnings which does not really make sense in this context. In addition those 'useless' warnings flood the CI.
In this PR we:
- remove from the tests 'BezierTetrahedron.scn' as it depend on a plugin.HighOrder
- use msg_info instead of serr in BaseDeformationMapping
The component prints stuff that are really looking like info/debug
messages and I see ne reason why they should be error or warning.
In addition using 'sout/serr' is bad:
- it has an inconsistent naming as it emits warning (while users expect an error).
- it does not add the filename/line from where the message is emitted while msg_info does
So if, in a private fork, you want/need to continue to use the old 'serr' backend...please make your own macro
route msg_info to the 'old' sout/serr backend instead of the one provided in Sofa.
- Fix examples/material/StVenantKirchoff.scn broken since the merge of In #PR 243 the following change was introduced in MechanicalObject.inl::init():
```cpp
if (!l_topology && d_useTopology.getValue())
{
l_topology.set( this->getContext()->getActiveMeshTopology() );
}
```
In place of
```cpp
//Look at a topology associated to this instance of MechanicalObject by a tag
this->getContext()->get(m_topology, this->getTags());
// If no topology found, no association, then look to the nearest one
if(m_topology == NULL)
m_topology = this->getContext()->getMeshTopology();
```
I assume that the in the scene was the EdgeSetTopologyContainer is not returned by
the getActiveMeshTopology method.
NB: All those implicit linking looks really problematic to me as they are error prone.#PR 243
The plugin is broken since PR sofa-framework#549 as it removes the initialization of the mutex. Possible explaination is that v_ is implementation dependent but the existing initialization was done incorrectly using a (int). Now use BOOST_DETAIL_SPINLOCK_INIT which insure that the initialization is coherent with the implementation used. (I also cannot prevent myself to remove the two ugly commented lines)
The <include> directive was using local path instead of relative to the 'example' directory as other examples. NB: I wonder why the shared "Object" directory is in examples. If it is shared between different examples scenes shouldn't it be in the 'share' directory ?
The color is encoded as a Vec4 not a Vec3
The points are now generated in the topology and can thus be used by the mechanical model. Note: I wonder how this was scene has ever worked. If any one knows please tell, because my fix may not be the right way.
I remove the <EdgeSet /> because it seems to be a component that does not exists anymore in Sofa.
damienmarchal
changed the title
damienmarchal
added
pr: fix
|
Thank you for this massive work Damien! |
|
[ci-build][with-scene-tests] |
hugtalbot
approved these changes
Jan 19, 2018
|
My bad for Windows error, the dependency pack was updated too soon. #566 needs to be merged. In the meantime I restart your build with the old dependency pack ;-) |
|
Before to merge ...wait the discussion with @epernod about cubetopology. |
|
Ok. Discussion is in 47ef2e6 |
|
Any update on the discussion @damienmarchal @epernod ? |
guparan
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up #548
My last batch of changes to fix the CI. Please review :)
This PR:
Reviewers will merge only if all these checks are true.