Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change log encoding configuration #13

Closed
hongweiyi opened this issue Apr 25, 2018 · 1 comment
Closed

Change log encoding configuration #13

hongweiyi opened this issue Apr 25, 2018 · 1 comment
Labels
dev:tuning Some improvement
Milestone
v1.4.2 release

Comments

@hongweiyi
Copy link

hongweiyi commented Apr 25, 2018 •
edited
Loading

BOLT use -Dcom.alipay.remoting.client.log.encode to control bolt framework log encoding, why not use file.encoding directly? Just like sofa-rpc log-conf.xml, so developers can use one configuration to control all logs encoding.
@xmtsui
Copy link
Member

xmtsui commented Apr 26, 2018

good suggestion, will fix this in 1.4.2

@xmtsui xmtsui added this to the v1.4.2 release milestone Apr 26, 2018
@xmtsui xmtsui added the dev:tuning Some improvement label Apr 26, 2018
xmtsui added a commit that referenced this issue May 17, 2018
@xmtsui
(tuning) fix #13
6679d61
This was referenced May 17, 2018
Closed
Merged
xmtsui added a commit that referenced this issue May 17, 2018
@xmtsui
(tuning) log conf modify (#25)
a1aa575 
fix #12  #13
@xmtsui xmtsui closed this as completed Jun 4, 2018
xmtsui pushed a commit that referenced this issue Jun 20, 2018
@yangl @xmtsui
[feature] support native transport (epoll) (#34)
4a8b9e8 
* (tuning) refactor start logic of remoting server

fix #8 (#21)

* tuning init logic of rpc server (#20)

fix #18

* (tuning) modify buffer allocator type

 fix #9 (#23)

* (format) modify header format (#24)

fix #10

* (tuning) log conf modify (#25)

fix #12  #13

* (format) modify license format

* fix maven-javadoc-plugin build ERROR with JDK 1.8 (#28)

* fix threadpools shutdown problems (issues 14) (#31)

单测待补充，先合并

* [feature] support the native transport

* merge feature/1.4.2

* [feature] support native transport (epoll)

* add autor

* make the bossGroup not deamon

* (bugfix) modify boss threadpool back to non-daemon

* [feature] support the native transport

* merge feature/1.4.2

* [feature] support native transport (epoll)

* add autor

* make the bossGroup not deamon

* rebase 1.4.2

* (feature) Netty epoll switch

* (version) modify release version

* Tuning/threadpool exit (#36)

* (tuning) change command factory visibility (#37)

* format error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:tuning Some improvement
Projects
None yet
Milestone
v1.4.2 release
Development

Successfully merging a pull request may close this issue.

Tuning/support common log encode sofastack/sofa-bolt
2 participants
@xmtsui @hongweiyi