fix threadpools shutdown problems (issues 14) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujjboy
reviewed
May 22, 2018
| */ | ||
| @Override | ||
| public void shutdown() { | ||
| workerGroup.shutdownGracefully(); |
There was a problem hiding this comment.
workerGroup 应该是全局的，在一个非static方法里关掉会不会有问题？
|
@ujjboy workerGroup静态变量问题已修复 |
|
@yangl format的问题，麻烦再提交一下哈。现在check format还是不过 |
|
invokeWithFuture及invokeWithCallback 没有关闭，应该是因为HashedWheelTimer的线程是非daemon的导致。这个可以也改一下 |
|
嗯 这个加的有 |
|
@yangl 整体看了下PR，客户端的问题应该没有了，其他有如下几个问题哈：
|
|
|
commit 0639872 rollback modification for boss group |
xmtsui
pushed a commit
that referenced
this pull request
Jun 20, 2018
* (tuning) refactor start logic of remoting server fix #8 (#21) * tuning init logic of rpc server (#20) fix #18 * (tuning) modify buffer allocator type fix #9 (#23) * (format) modify header format (#24) fix #10 * (tuning) log conf modify (#25) fix #12 #13 * (format) modify license format * fix maven-javadoc-plugin build ERROR with JDK 1.8 (#28) * fix threadpools shutdown problems (issues 14) (#31) 单测待补充，先合并 * [feature] support the native transport * merge feature/1.4.2 * [feature] support native transport (epoll) * add autor * make the bossGroup not deamon * (bugfix) modify boss threadpool back to non-daemon * [feature] support the native transport * merge feature/1.4.2 * [feature] support native transport (epoll) * add autor * make the bossGroup not deamon * rebase 1.4.2 * (feature) Netty epoll switch * (version) modify release version * Tuning/threadpool exit (#36) * (tuning) change command factory visibility (#37) * format error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.