fix elect priority #357
Merged
fix elect priority #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
reviewed
Nov 27, 2019
| final long nextIndex = Replicator.getNextIndex(entry.getValue()); | ||
| if (nextIndex > maxIndex) { | ||
| if (nextIndex >= maxIndex && nextPriority > priority) { |
There was a problem hiding this comment.
这个改动可能是有问题的，改变了原来的语义。在没有启用 priority 的情况下，是选择出复制最多数据(nextIndex 最大）的节点来作为下一个 leader；改动后，同样在没有启用 priority 的情况下，不会去选择出复制最多（因为 nextPriority > priority 这个条件），可能需要将 nextPriority > priority 改成 nextPriority >= priority
There was a problem hiding this comment.
恩，这里有问题，又改了这段逻辑你再看下
killme2008
approved these changes
Nov 27, 2019
|
赞！这里是我开始时候没有考虑到的点，感谢家纯帮忙fix，感谢伯岩的review哈 @fengjiachun @killme2008 |
luozhiyun993
pushed a commit
to luozhiyun993/sofa-jraft
that referenced
this pull request
Nov 28, 2019
* 'master' of https://github.com/sofastack/sofa-jraft: Feature/some changes (sofastack#358) fix elect priority (sofastack#357) Remove unused imports (sofastack#356) feat/priority_by_zongtanghu (sofastack#345)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When leader stepdown, select (maxIndex, maxPriority) as next candidate
Modification:
Result: