Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/some changes #358

Merged
merged 7 commits into from
Nov 28, 2019
Merged

Feature/some changes #358

merged 7 commits into from
Nov 28, 2019

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Nov 27, 2019 •
edited
Loading

This PR contains following modifications:

  • Randomize first snapshot timeout. In multi raft group, one java process may have several raft groups, they almost startup at same time and will do snapshot at the same time, make the java process has too much pressure.
  • LogManager#getTerm should check if index<firstLogIndex.
  • Candidate should steps down when election reaching vote timeout, this idea comes from baidu/braft@725242d
  • Adds MAVEN_OPTS to travis test.

@sofastack-bot
Copy link

sofastack-bot bot commented Nov 27, 2019

Hi @killme2008, we detect non-English characters in the issue. This comment is an auto translation by @sofastack-robot to help other users to understand this issue.

We encourage you to describe your issue in English which is more friendly to other users.

EVERYTHING: describe modification

@killme2008
Copy link
Contributor Author

@fengjiachun 设置了 jvm 参数后，测试时长缩短到 19min，立竿见影

@fengjiachun fengjiachun merged commit 57070d9 into master Nov 28, 2019
@fengjiachun fengjiachun deleted the feature/some-changes branch November 28, 2019 10:18
luozhiyun993 pushed a commit to luozhiyun993/sofa-jraft that referenced this pull request Nov 28, 2019
Merge branch 'master' of https://github.com/sofastack/sofa-jraft
5f1adec 
* 'master' of https://github.com/sofastack/sofa-jraft:
  Feature/some changes (sofastack#358)
  fix elect priority (sofastack#357)
  Remove unused imports (sofastack#356)
  feat/priority_by_zongtanghu (sofastack#345)
@fengjiachun fengjiachun mentioned this pull request Nov 29, 2019
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
cla:yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killme2008 @fengjiachun