Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked deploy and declare #573

Merged
merged 24 commits into from
Aug 9, 2022
Merged

Reworked deploy and declare #573

merged 24 commits into from
Aug 9, 2022

Conversation

Radinyn
Copy link
Contributor

@Radinyn Radinyn commented Aug 3, 2022

No description provided.

@Radinyn Radinyn linked an issue Aug 3, 2022 that may be closed by this pull request
@Radinyn Radinyn marked this pull request as ready for review August 5, 2022 12:07
@Radinyn Radinyn requested review from mkaput, MaksymilianDemitraszek and kasperski95 and removed request for mkaput August 5, 2022 12:07
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #573 (46360cc) into master (87dbd6d) will decrease coverage by 0.24%.
The diff coverage is 82.38%.

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   82.96%   82.72%   -0.25%     
==========================================
  Files         186      189       +3     
  Lines        6188     6279      +91     
==========================================
+ Hits         5134     5194      +60     
- Misses       1054     1085      +31     
Impacted Files Coverage Δ
protostar/commands/migrate/migrate_command_test.py 100.00% <ø> (ø)
protostar/composition_root.py 100.00% <ø> (ø)
protostar/migrator/migrator_cheatcodes_factory.py 100.00% <ø> (ø)
...ostar/commands/test/test_environment_exceptions.py 92.26% <27.27%> (-4.21%) ⬇️
...star/commands/test/cheatcodes/declare_cheatcode.py 45.45% <66.66%> (-5.61%) ⬇️
...mands/test/cheatcodes/deploy_contract_cheatcode.py 56.00% <66.66%> (-4.00%) ⬇️
protostar/migrator/migrator.py 88.46% <72.22%> (-6.28%) ⬇️
protostar/starknet_gateway/gateway_facade.py 83.50% <82.45%> (-6.21%) ⬇️
...r/cheatcodes/migrator_deploy_contract_cheatcode.py 92.10% <84.61%> (-4.45%) ⬇️
.../migrator/cheatcodes/migrator_declare_cheatcode.py 94.87% <85.71%> (-5.13%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move documentation changes to separate PR? Would be easier to review.

@Radinyn Radinyn self-assigned this Aug 5, 2022
@Radinyn Radinyn requested review from kasperski95 and mkaput August 8, 2022 12:20
@Radinyn Radinyn requested a review from kasperski95 August 9, 2022 10:59
@Radinyn Radinyn merged commit 9c4c818 into master Aug 9, 2022
@Radinyn Radinyn deleted the refactor/deploy_and_declare branch August 9, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use StarkNet.py for deploy and declare. Support waiting for acceptance.
3 participants