Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy and declare docs #588

Merged
merged 10 commits into from
Aug 9, 2022
Merged

deploy and declare docs #588

merged 10 commits into from
Aug 9, 2022

Conversation

Radinyn
Copy link
Contributor

@Radinyn Radinyn commented Aug 5, 2022

No description provided.

@Radinyn Radinyn self-assigned this Aug 5, 2022
@Radinyn Radinyn requested a review from mkaput August 8, 2022 12:36
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #588 (4d9ec33) into master (44d5ee0) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #588      +/-   ##
==========================================
- Coverage   82.96%   82.72%   -0.25%     
==========================================
  Files         186      189       +3     
  Lines        6188     6279      +91     
==========================================
+ Hits         5134     5194      +60     
- Misses       1054     1085      +31     
Impacted Files Coverage Δ
protostar/starknet_gateway/network_config.py 79.31% <0.00%> (-15.69%) ⬇️
protostar/migrator/migrator.py 88.46% <0.00%> (-6.28%) ⬇️
protostar/starknet_gateway/gateway_facade.py 83.50% <0.00%> (-6.21%) ⬇️
...star/commands/test/cheatcodes/declare_cheatcode.py 45.45% <0.00%> (-5.61%) ⬇️
.../migrator/cheatcodes/migrator_declare_cheatcode.py 94.87% <0.00%> (-5.13%) ⬇️
...ostar/commands/test/cheatcodes/deploy_cheatcode.py 60.86% <0.00%> (-4.52%) ⬇️
...r/cheatcodes/migrator_deploy_contract_cheatcode.py 92.10% <0.00%> (-4.45%) ⬇️
...ostar/commands/test/test_environment_exceptions.py 92.26% <0.00%> (-4.21%) ⬇️
...mands/test/cheatcodes/deploy_contract_cheatcode.py 56.00% <0.00%> (-4.00%) ⬇️
protostar/utils/protostar_directory.py 58.97% <0.00%> (-1.64%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Radinyn Radinyn requested a review from mkaput August 8, 2022 13:05
@kasperski95
Copy link
Contributor

Blocked by #573

Copy link
Contributor

@kasperski95 kasperski95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's unnecessary information about network config in testing cheatcodes

@Radinyn Radinyn requested a review from kasperski95 August 9, 2022 12:45
Copy link
Contributor

@kasperski95 kasperski95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone may think that there's a migration cheatcode in the testing environment.

Radinyn and others added 2 commits August 9, 2022 14:54
Co-authored-by: Arkadiusz <arkadiusz.kasprzyk@swmansion.com>
…t.md

Co-authored-by: Arkadiusz <arkadiusz.kasprzyk@swmansion.com>
@Radinyn Radinyn merged commit ac36eb1 into master Aug 9, 2022
@Radinyn Radinyn deleted the refactor/deploy_and_declare_docs branch August 9, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants