Skip to content

Commit

Permalink
Adjust Progress Processorss (#637)
Browse files Browse the repository at this point in the history
This PR changes the maximum progress for iOS and android build from 1 to
0.999 to avoid situations in which users are send 100% for prolonged
periods of time.

### How Has This Been Tested: 

- run clean build in any test app
  • Loading branch information
filip131311 authored Oct 18, 2024
1 parent bff32af commit cf7a896
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ export class BuildAndroidProgressProcessor implements BuildProgressProcessor {
if (!this.tasksToComplete) {
return;
}
this.progressListener(Math.min(1, this.completedTasks / this.tasksToComplete));
// the 0.999 max value is here to prevent situations in which users see 100% indiction,
// but the build process is still takeing a couple more seconds.
this.progressListener(Math.min(0.999, this.completedTasks / this.tasksToComplete));
}

processLine(line: string): void {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ export class BuildIOSProgressProcessor implements BuildProgressProcessor {
if (!this.tasksToComplete) {
return;
}
this.progressListener(Math.min(1, this.completedTasks / this.tasksToComplete));
// the 0.999 max value is here to prevent situations in which users see 100% indiction,
// but the build process is still takeing a couple more seconds.
this.progressListener(Math.min(0.999, this.completedTasks / this.tasksToComplete));
}

async processLine(line: string) {
Expand Down

0 comments on commit cf7a896

Please sign in to comment.