Adjust Progress Processorss #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kmagiera
approved these changes
Oct 18, 2024
| @@ -10,7 +10,7 @@ export class BuildAndroidProgressProcessor implements BuildProgressProcessor { | |||
| if (!this.tasksToComplete) { | |||
| return; | |||
| } | |||
| this.progressListener(Math.min(1, this.completedTasks / this.tasksToComplete)); | |||
| this.progressListener(Math.min(0.999, this.completedTasks / this.tasksToComplete)); | |||
There was a problem hiding this comment.
This just looks very weird and should be explained in the comment
| @@ -65,7 +65,7 @@ export class BuildIOSProgressProcessor implements BuildProgressProcessor { | |||
| if (!this.tasksToComplete) { | |||
| return; | |||
| } | |||
| this.progressListener(Math.min(1, this.completedTasks / this.tasksToComplete)); | |||
| this.progressListener(Math.min(0.999, this.completedTasks / this.tasksToComplete)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the maximum progress for iOS and android build from 1 to 0.999 to avoid situations in which users are send 100% for prolonged periods of time.
How Has This Been Tested: