Fix JSON reporter for Expo #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we overrode metro-config to inject our config in Expo apps because Expo doesn't allow for customizing metro config directly. Expo generates config based on metro-config but then customizes it. [1] To work around that, we plug our config later in a flow, directly before Metro is started. [1]: https://github.com/expo/expo/blob/a208802b51c73a2799048d30f1d4b9240bffc6c0/packages/%40expo/cli/src/start/server/metro/instantiateMetro.ts#L94-L108
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kmagiera
requested changes
Jun 25, 2024
There was a problem hiding this comment.
As discussed offline. Would be good to avoid importing internals from expo cli especially that we already had issues with some changes related to bundling in the past. There is setEventReporter method that's exposed from the config loader in cli codebase. Perhaps we could use that one?
kmagiera
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we overrode metro-config to inject our config in Expo apps because Expo doesn't allow for customizing metro config directly.
Expo generates config based on metro-config but then customizes it by overriding reporter setting (see here
To work around that, we replace the base class for TerminalReporter that expo CLI uses with out metro_reporter that we want to set as the reporter in configuration.
Test plan: