Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON reporter for Expo #399

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Fix JSON reporter for Expo #399

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f2e6fb
Fix JSON reporter for Expo
jakub-gonet Jun 21, 2024
89bceb2
Merge remote-tracking branch 'origin/main' into jgonet/fix-metro-repo…
kmagiera Jul 11, 2024
4795696
Override terminal reporter
kmagiera Jul 11, 2024
dc82d90
Override terminal reporter
kmagiera Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/vscode-extension/lib/expo_start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ metroConfig.loadConfig = async function (...args) {
return adaptMetroConfig(config);
};

// Furthermore, expo CLI also does override the reporter setting despite it being
// set in the config. In order to force CLI to use JSON reporter, we override
// base terminal reporter class from metro that Expo CLI extends
overrideModuleFromAppDir("metro/src/lib/TerminalReporter", require("./metro_reporter"));

// In addition, expo uses freeport-async to check whether provided port is busy.
// Apparently, this module returns 11000 port when 0 is provided, so we need to
// override this behavior here.
Expand Down