Disable default context menu on windows #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
filip131311
commented
Oct 10, 2024
kmagiera
approved these changes
Oct 11, 2024
| return () => removeEventListener("blur", onBlurChange, true); | ||
| return () => { | ||
| window.removeEventListener("contextmenu", onContextMenu); | ||
| removeEventListener("blur", onBlurChange, true); |
There was a problem hiding this comment.
can we update removeEventListener here and also corresponding addEventLIstener call to specify whether it operates on document or window (or something else?)
filip131311
added a commit
that referenced
this pull request
Oct 18, 2024
This PR fixes the behavior of right click when using inspector tool, it removes the old `ContexMenu` in favor of `DropdownMenu`, which is more appropriate as it does not require `contextmenu` event to be activated, which since #608 is disabled. ### How Has This Been Tested: - run any test application and use right click to inspect a component - use inspector button and right click while it is active --------- Co-authored-by: Paweł Małecki <92953623+p-malecki@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables default context menu on windows, as it clashed with right-click inspector functionality.
Test plan: