Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inspector right click #636

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fix Inspector right click #636

merged 2 commits into from
Oct 18, 2024

Conversation

filip131311
Copy link
Collaborator

This PR fixes the behavior of right click when using inspector tool, it removes the old ContexMenu in favor of DropdownMenu, which is more appropriate as it does not require contextmenu event to be activated, which since #608 is disabled.

How Has This Been Tested:

  • run any test application and use right click to inspect a component
  • use inspector button and right click while it is active

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 9:03am

Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember there was some issue with the right-click on windows which was also activaing the built-in context menu. Therefore this needs to be tested on Windows as well.

@filip131311 filip131311 merged commit 79675ad into main Oct 18, 2024
3 checks passed
@filip131311 filip131311 deleted the @Filip131311/FixInspector branch October 18, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants