Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Worklets): Create a stub of Worklets Module #6539

Merged
merged 67 commits into from
Nov 19, 2024
Merged

feat(Worklets): Create a stub of Worklets Module #6539

merged 67 commits into from
Nov 19, 2024

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Sep 23, 2024 •
edited
Loading

This pull request is one of many which replace

since that PR is extensive and too difficult to review.

Summary

Adding a second Native Module for Worklets.

It's initial responsibility for now is forwarding valueUnpackerCode to Reanimated Module. While it seems silly, it's a good start since it sets up the whole pipeline of:

typescript
├── android
│   └── cpp
└── ios
    └── cpp

(I was too lazy to use mermaid, long live mkdir -p)

Follow up PRs will move more and more responsibilities from Reanimated to Worklets.

Requires:

Test plan

  • All GitHub Actions pass
  • Compatibility Github Action passes
  • debug Android works
  • release Android works
  • debug iOS works
  • release iOS works

piaskowyk
piaskowyk reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks ok 👍

packages/react-native-reanimated/src/worklets/native/NativeWorklets.ts Outdated Show resolved Hide resolved
packages/react-native-reanimated/src/NativeReanimated/NativeReanimated.ts Outdated Show resolved Hide resolved
packages/react-native-reanimated/src/NativeReanimated/NativeReanimated.ts Outdated Show resolved Hide resolved
packages/react-native-reanimated/apple/worklets/WorkletsModule.mm Outdated Show resolved Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.cpp Outdated Show resolved Hide resolved
packages/react-native-reanimated/Common/cpp/worklets/Tools/JSScheduler.cpp Outdated Show resolved Hide resolved
@tjzel tjzel force-pushed the @tjzel/worklets/native-worklets-module-stub branch from ee1d2f9 to a513d82 Compare September 24, 2024 17:22
@tjzel tjzel added the Check compatibility Trigger a time-consuming compatibility check action label Sep 25, 2024
WoLewicki
WoLewicki reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, please answer them.

packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.h Outdated Show resolved Hide resolved
packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModule.cpp Outdated Show resolved Hide resolved
packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModule.cpp Outdated Show resolved Hide resolved
packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModuleSpec.cpp Outdated Show resolved Hide resolved
packages/react-native-reanimated/android/src/main/cpp/reanimated/CMakeLists.txt Outdated Show resolved Hide resolved
packages/react-native-reanimated/apple/worklets/WorkletsModule.mm Outdated Show resolved Hide resolved
packages/react-native-reanimated/apple/worklets/WorkletsModule.mm Outdated Show resolved Hide resolved
@tjzel tjzel mentioned this pull request Oct 30, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2024
@tjzel
chore: Add noop typescript worklets module (#6650)
f820cba 
## Summary

Preparing for #6539 

## Test plan

This PR has no real runtime impact
@tjzel tjzel changed the base branch from main to @tjzel/remove-code-below-74 November 11, 2024 16:46
Base automatically changed from @tjzel/remove-code-below-74 to main November 11, 2024 18:29
tomekzaw
tomekzaw approved these changes Nov 19, 2024
View reviewed changes
packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModuleSpec.cpp Outdated Show resolved Hide resolved
packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModuleSpec.cpp Show resolved Hide resolved
packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModuleSpec.h Show resolved Hide resolved
packages/react-native-reanimated/android/src/main/cpp/worklets/android/WorkletsModule.cpp Show resolved Hide resolved
packages/react-native-reanimated/android/src/main/cpp/worklets/android/WorkletsModule.cpp Show resolved Hide resolved
...ges/react-native-reanimated/android/src/main/java/com/swmansion/worklets/WorkletsModule.java Outdated Show resolved Hide resolved
@tjzel tjzel added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit 6fad03e Nov 19, 2024
43 of 45 checks passed
@tjzel tjzel deleted the @tjzel/worklets/native-worklets-module-stub branch November 19, 2024 14:10
@gaearon gaearon mentioned this pull request Dec 9, 2024
Closed
@gaearon
Copy link
Contributor

gaearon commented Dec 9, 2024

This might have introduced a crash. #6802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoLewicki WoLewicki WoLewicki left review comments

@piaskowyk piaskowyk piaskowyk approved these changes

@tomekzaw tomekzaw tomekzaw approved these changes

@bartlomiejbloniarz bartlomiejbloniarz Awaiting requested review from bartlomiejbloniarz

Assignees
No one assigned
Labels
Check compatibility Trigger a time-consuming compatibility check action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tjzel @tomekzaw @gaearon @WoLewicki @piaskowyk