refactor(Worklets): Merge TypeScript type files #6556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2024
tjzel
changed the title
tomekzaw
approved these changes
Oct 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
## Summary Requires: - #6556 QoL refactor that will allow easier NativeWorkletsModule embedment. Summary: `NativeReanimated.ts` -> `ReanimatedModule/NativeReanimated.ts` `js-reanimated/` -> `ReanimatedModule/js-reanimated` `NativeReanimatedModule` and `JSReanimatedModule` aren't exported anymore. The only way to obtain them is via `createReanimatedModule`, that should yield less error prone code. `NativeWorkletsModule` will follow the same pattern. ## Test plan - [x] CI green :shrek:
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
This pull request is one of many which replace - #6378 since that PR is extensive and too difficult to review. ## Summary Adding a second Native Module for Worklets. It's initial responsibility for now is forwarding `valueUnpackerCode` to Reanimated Module. While it seems silly, it's a good start since it sets up the whole pipeline of: ```tree typescript ├── android │ └── cpp └── ios └── cpp ``` (I was too lazy to use mermaid, long live `mkdir -p`) Follow up PRs will move more and more responsibilities from Reanimated to Worklets. Requires: - #6556 - #6557 ## Test plan - [x] All GitHub Actions pass - [x] Compatibility Github Action passes - [x] debug Android works - [x] release Android works - [x] debug iOS works - [x] release iOS works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Required by:
NativeReanimatedModuledepends on types from Layout Animations - this makes impossible to embed its interface incommonTypes.tssince they can't have any imports. I merged some types to prevent circular dependencies.Test plan