feat: warn when using native-stack from rns in v6 #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
reviewed
Aug 18, 2021
satya164
reviewed
Aug 18, 2021
WoLewicki
approved these changes
Aug 19, 2021
kacperkapusciak
deleted the
@kacperkapusciak/warn-native-stack-use-in-v6
branch
|
it seems that |
|
It broke my app, and i had to change it back to |
|
Hi @kneza23, Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since react-navigation v6
@react-navigation/native-stackis the preferred way of using native-stack. Nevertheless, nothing stops developers from usingreact-native-screens/native-stackwith RNv6. This PR adds a check if react-native-screens' native-stack is used with RNv6 and warns about this.Screenshots / GIFs
Test code and steps to reproduce
Bump @react-navigation/native in TestsExample to use v6.
Checklist