Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warn when using native-stack from rns in v6 #1058

Merged
merged 2 commits into from
Aug 19, 2021
Merged

feat: warn when using native-stack from rns in v6 #1058

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
997a18d
feat: warn when using native-stack from rns in v6
kacperkapusciak Aug 18, 2021
7c22e55
fix: comment, make warning message less formal
kacperkapusciak Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/native-stack/navigators/createNativeStackNavigator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,17 @@ function NativeStackNavigator({
screenOptions,
});

// Starting from React Navigation v6, `native-stack` should be imported from
// `@react-navigation/native-stack` rather than `react-native-screens/native-stack`
React.useEffect(() => {
// @ts-ignore navigation.dangerouslyGetParent was removed in v6
if (navigation?.dangerouslyGetParent === undefined) {
console.warn(
'Looks like you are importing `native-stack` from `react-native-screens/native-stack`. Since version 6 of `react-navigation`, it should be imported from `@react-navigation/native-stack`.'
);
}
}, [navigation]);

React.useEffect(
() =>
navigation?.addListener?.('tabPress', (e) => {
Expand Down