-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Android): add autolinking on Fabric #1585
Commits on Sep 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d5a9109 - Browse repository at this point
Copy the full SHA d5a9109View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f84579 - Browse repository at this point
Copy the full SHA 4f84579View commit details -
Configuration menu - View commit details
-
Copy full SHA for da0faed - Browse repository at this point
Copy the full SHA da0faedView commit details
Commits on Sep 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e177bf4 - Browse repository at this point
Copy the full SHA e177bf4View commit details -
chore: copy codegened implementation of cpp code for RNSScreen
For now it is only partially filtered (there is also code for other components for now). I'm not sure whether I should leave all the codegened code or leave only the RNSScreen part.
Configuration menu - View commit details
-
Copy full SHA for d3b7f73 - Browse repository at this point
Copy the full SHA d3b7f73View commit details -
chore: remove ComponentsDescriptors.h
As we provide custom implementation
Configuration menu - View commit details
-
Copy full SHA for da63061 - Browse repository at this point
Copy the full SHA da63061View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7963fd0 - Browse repository at this point
Copy the full SHA 7963fd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 882f032 - Browse repository at this point
Copy the full SHA 882f032View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57f3346 - Browse repository at this point
Copy the full SHA 57f3346View commit details -
Configuration menu - View commit details
-
Copy full SHA for d54857f - Browse repository at this point
Copy the full SHA d54857fView commit details -
fix: add all components descriptors & specify cmakeListsPath
Setting `componentDescriptors` causes RNCLI to not search for autogenerated ones -> we need to specify all of them manually
Configuration menu - View commit details
-
Copy full SHA for 0ccc2ea - Browse repository at this point
Copy the full SHA 0ccc2eaView commit details -
chore: build custom & generated code with cmake
This CMake builds both custom cpp code & generated one. It seems to me, that it must be done this way as project name recognized by autogenerated RN CLI cmake is `react_codegen_rnscreens` and we can not change that => only this library is included in final build.
Configuration menu - View commit details
-
Copy full SHA for b8ccfa3 - Browse repository at this point
Copy the full SHA b8ccfa3View commit details
Commits on Sep 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1a00f6a - Browse repository at this point
Copy the full SHA 1a00f6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1d5f3e - Browse repository at this point
Copy the full SHA e1d5f3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba5252b - Browse repository at this point
Copy the full SHA ba5252bView commit details -
Configuration menu - View commit details
-
Copy full SHA for de99905 - Browse repository at this point
Copy the full SHA de99905View commit details
Commits on Sep 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 449316f - Browse repository at this point
Copy the full SHA 449316fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29bd651 - Browse repository at this point
Copy the full SHA 29bd651View commit details -
chore: add common/cpp as include directory for application project
IMPORTANT: this causes our custom `rnscreens.h` header to take precedence over its codegened counterpart when imported in following way in `rncli.cpp`: ```c++ ``` This is important beacuse it allows us to inject `RNSScreenComponentDescriptor` symbol into `rncli.cpp` translation unit scope.
Configuration menu - View commit details
-
Copy full SHA for 8e011e7 - Browse repository at this point
Copy the full SHA 8e011e7View commit details -
chore: do not manually load rnscreens_modules shared library
We no longer build this target as we want to rely on new Android autolinking.
Configuration menu - View commit details
-
Copy full SHA for 81b86ad - Browse repository at this point
Copy the full SHA 81b86adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b56ca7 - Browse repository at this point
Copy the full SHA 4b56ca7View commit details -
fix: enforce non-local visibility of getDynamic symbol of
libreact_codegen_rnscreens.so library This symbol for some, unknown yet reason, is not visible during linking of lib<project-name>.so (exactly during linking rncli.cpp.o file). We enforce desired visibility with compiler attributte. Note however that this solution should be only temporary as the exact reason should be tracked down and the issue shall be fixed with more generic approach.
Configuration menu - View commit details
-
Copy full SHA for 05de5a5 - Browse repository at this point
Copy the full SHA 05de5a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b573d77 - Browse repository at this point
Copy the full SHA b573d77View commit details -
chore: remove unused common/cpp/Android.mk file
This file is not only no longer used, but also it does not contain valid configuration for our library. This file was replaced with common/cpp/CMakeLists.txt as we migrated to CMake build system.
Configuration menu - View commit details
-
Copy full SHA for 7bd60c4 - Browse repository at this point
Copy the full SHA 7bd60c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2a4909 - Browse repository at this point
Copy the full SHA e2a4909View commit details
Commits on Sep 15, 2022
-
chore: generalise path resolution in CMake
Up to this point, some paths were hardcoded, this is no longer the case.
Configuration menu - View commit details
-
Copy full SHA for 007895b - Browse repository at this point
Copy the full SHA 007895bView commit details -
This is temporary workaround as `rnscreens.{h,cpp}` files are not part of common cpp code - they are android specific I believe. They must be moved to android JNI directory along with CMakeLists.txt
Configuration menu - View commit details
-
Copy full SHA for c94c6e8 - Browse repository at this point
Copy the full SHA c94c6e8View commit details -
chore: move Android specific configuration & cpp files to Android
specific directory These files are not shared between iOS & Android platforms.
Configuration menu - View commit details
-
Copy full SHA for 5d4912c - Browse repository at this point
Copy the full SHA 5d4912cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48630ec - Browse repository at this point
Copy the full SHA 48630ecView commit details
Commits on Sep 16, 2022
-
chore: use JSI_EXPORT macro instead of setting compiler attribute
explicitly This is better as it also handles Windows C++ compilers.
Configuration menu - View commit details
-
Copy full SHA for 2cfe611 - Browse repository at this point
Copy the full SHA 2cfe611View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ce7490 - Browse repository at this point
Copy the full SHA 8ce7490View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d9f573 - Browse repository at this point
Copy the full SHA 0d9f573View commit details -
Configuration menu - View commit details
-
Copy full SHA for 213e592 - Browse repository at this point
Copy the full SHA 213e592View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c00515 - Browse repository at this point
Copy the full SHA 9c00515View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3afe846 - Browse repository at this point
Copy the full SHA 3afe846View commit details -
Configuration menu - View commit details
-
Copy full SHA for 509f1af - Browse repository at this point
Copy the full SHA 509f1afView commit details