chore(Android): add autolinking on Fabric #1585
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| cmake_minimum_required(VERSION 3.13) | ||
| set(CMAKE_VERBOSE_MAKEFILE ON) | ||
|
|
||
| set(LIB_LITERAL rnscreens) | ||
| set(LIB_TARGET_NAME react_codegen_${LIB_LITERAL}) | ||
|
|
||
| set(LIB_ANDROID_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../../..) | ||
| set(LIB_COMMON_DIR ${LIB_ANDROID_DIR}/../common/cpp) | ||
| set(LIB_ANDROID_GENERATED_JNI_DIR ${LIB_ANDROID_DIR}/build/generated/source/codegen/jni) | ||
| set(LIB_ANDROID_GENERATED_COMPONENTS_DIR ${LIB_ANDROID_GENERATED_JNI_DIR}/react/renderer/components/${LIB_LITERAL}) | ||
|
|
||
| add_compile_options( | ||
| -fexceptions | ||
| -frtti | ||
| -std=c++17 | ||
| -Wall | ||
| -Wpedantic | ||
| -Wno-gnu-zero-variadic-macro-arguments | ||
| ) | ||
|
|
||
| file(GLOB LIB_CUSTOM_SRCS CONFIGURE_DEPENDS *.cpp ${LIB_COMMON_DIR}/react/renderer/components/${LIB_LITERAL}/*.cpp) | ||
| file(GLOB LIB_CODEGEN_SRCS CONFIGURE_DEPENDS ${LIB_ANDROID_GENERATED_COMPONENTS_DIR}/*.cpp) | ||
|
|
||
| add_library( | ||
| ${LIB_TARGET_NAME} | ||
| SHARED | ||
| ${LIB_CUSTOM_SRCS} | ||
| ${LIB_CODEGEN_SRCS} | ||
| ) | ||
|
|
||
| target_include_directories( | ||
| ${LIB_TARGET_NAME} | ||
| PUBLIC | ||
| . | ||
| ${LIB_COMMON_DIR} | ||
| ${LIB_ANDROID_GENERATED_JNI_DIR} | ||
| ${LIB_ANDROID_GENERATED_COMPONENTS_DIR} | ||
| ) | ||
|
|
||
| target_link_libraries( | ||
| ${LIB_TARGET_NAME} | ||
| fbjni | ||
| folly_runtime | ||
| glog | ||
| jsi | ||
| react_codegen_rncore | ||
| react_debug | ||
| react_nativemodule_core | ||
| react_render_core | ||
| react_render_debug | ||
| react_render_graphics | ||
| react_render_mapbuffer | ||
| rrc_view | ||
| turbomodulejsijni | ||
| yoga | ||
| ) | ||
|
|
||
| target_compile_options( | ||
| ${LIB_TARGET_NAME} | ||
| PRIVATE | ||
| -DLOG_TAG=\"ReactNative\" | ||
| -fexceptions | ||
| -frtti | ||
| -std=c++17 | ||
| -Wall | ||
| ) | ||
|
|
||
| target_include_directories( | ||
| ${CMAKE_PROJECT_NAME} | ||
| PUBLIC | ||
| ${CMAKE_CURRENT_SOURCE_DIR} | ||
| ) | ||
|
Comment on lines
+68
to
+72
There was a problem hiding this comment. This is required, so when preprocessor expands |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #include "rnscreens.h" | ||
kkafar marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| namespace facebook { | ||
| namespace react { | ||
|
|
||
|
|
||
| std::shared_ptr<TurboModule> rnscreens_ModuleProvider(const std::string &moduleName, const JavaTurboModule::InitParams ¶ms) { | ||
| return nullptr; | ||
| } | ||
|
|
||
| } // namespace react | ||
| } // namespace facebook | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| #pragma once | ||
|
|
||
| #include <ReactCommon/JavaTurboModule.h> | ||
| #include <ReactCommon/TurboModule.h> | ||
| #include <jsi/jsi.h> | ||
| #include <react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h> | ||
|
There was a problem hiding this comment. This include directive makes |
||
|
|
||
| namespace facebook { | ||
| namespace react { | ||
|
|
||
| JSI_EXPORT | ||
tomekzaw marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. It would be nice to add information why it is needed at all. |
||
| std::shared_ptr<TurboModule> rnscreens_ModuleProvider(const std::string &moduleName, const JavaTurboModule::InitParams ¶ms); | ||
|
|
||
| } // namespace react | ||
| } // namespace facebook | ||
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the changes needed in
rnsvg, maybe it would be good to add a comment that you should add here all libraries that your custom state depend on.