refact(TVOS): using common example src #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
maciekstosio
approved these changes
Jun 11, 2024
This was referenced Aug 20, 2024
This was referenced Aug 23, 2024
This was referenced Aug 30, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description This PR intents to use common examples src directory in TVOS Example app. The example screens that were removed with tvos specific src folder are all present in the common directory in similar or slightly more complex shape ready to be tested. Some of the common examples that are being exposed to TVOS by this PR are not working properly as they were not intended to work on TV platform, those are: - swipe back animation screen (working well, but without the gesture) - animations playground - status bar playground - orientation playground - search bar playground - gestures playground I decided to filter them out for TV devices. There are also some issues worth pointing out I found while playing around with the TVOS example: - header text and background colors are unchangeable (white on light grey in regular screens and gray on dark gray in modals) - the value in the input is not visible until the input is hovered or focused (try it in Stack Presentation -> formSheet) - select inputs are not selectable - just expandable, thus not accessible (try it in header options playground) ## Changes - removed TVOS src directory - linked apps/examples/App in TVOS App.tsx - added TVOS Platform ternary in common App.tsx file <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intents to use common examples src directory in TVOS Example app.
The example screens that were removed with tvos specific src folder are all present in the common directory in similar or slightly more complex shape ready to be tested.
Some of the common examples that are being exposed to TVOS by this PR are not working properly as they were not intended to work on TV platform, those are:
I decided to filter them out for TV devices.
There are also some issues worth pointing out I found while playing around with the TVOS example:
Changes
Test code and steps to reproduce
Checklist