Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix felt serialization in snforge-test-collector #1317

Closed
maciektr opened this issue May 22, 2024 · 0 comments · Fixed by #1318
Closed

Fix felt serialization in snforge-test-collector #1317

maciektr opened this issue May 22, 2024 · 0 comments · Fixed by #1318
Assignees
@Draggu
Labels
bug Something isn't working

Comments

@maciektr
Copy link
Contributor

Problem

scarb/extensions/scarb-snforge-test-collector/tests/test.rs

Line 288 in ad4020f

#[ignore = "TODO: fix felt serialization"]

Proposed Solution

No response

Notes

No response
@maciektr maciektr added the bug Something isn't working label May 22, 2024
@maciektr maciektr added this to Scarb May 22, 2024
@github-project-automation github-project-automation bot moved this to Triage in Scarb May 22, 2024
@Draggu Draggu mentioned this issue May 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 22, 2024
@Draggu
Fix felt serialization in snforge-test-collector (#1318)
2249e61 
Closes #1317

Fixes felt serialization in `snforge-test-collector` by using wrapper
with custom `serde::Serialize` implementation that is mimicking old
`Felt252` implementation (wrapper over `BigUint`)
@github-project-automation github-project-automation bot moved this from Triage to Done in Scarb May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Draggu Draggu

Labels
bug Something isn't working
Projects
Scarb
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix felt serialization in snforge-test-collector software-mansion/scarb
2 participants
@maciektr @Draggu