Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix felt serialization in snforge-test-collector #1318

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix felt serialization in snforge-test-collector #1318

merged 1 commit into from
May 22, 2024

Conversation

Draggu
Copy link
Contributor

@Draggu Draggu commented May 22, 2024

Closes #1317

Fixes felt serialization in snforge-test-collector by using wrapper with custom serde::Serialize implementation that is mimicking old Felt252 implementation (wrapper over BigUint)

@Draggu Draggu requested a review from maciektr as a code owner May 22, 2024 12:40
@maciektr maciektr requested a review from Arcticae May 22, 2024 13:32
@maciektr maciektr requested a review from piotmag769 May 22, 2024 13:36
@maciektr maciektr added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 2249e61 May 22, 2024
22 checks passed
@maciektr maciektr deleted the fix-felt-serialization branch May 22, 2024 13:55
@BrewTestBot BrewTestBot mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotmag769 piotmag769 piotmag769 approved these changes

@maciektr maciektr maciektr approved these changes

@Arcticae Arcticae Awaiting requested review from Arcticae

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix felt serialization in snforge-test-collector
3 participants
@Draggu @maciektr @piotmag769