Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include and exclude fields to Scarb.toml #644

Closed
mkaput opened this issue Sep 5, 2023 · 0 comments · Fixed by #746
Closed

Add include and exclude fields to Scarb.toml #644

mkaput opened this issue Sep 5, 2023 · 0 comments · Fixed by #746
Assignees

Comments

@mkaput
Copy link
Member

mkaput commented Sep 5, 2023

Basically implement this: https://doc.rust-lang.org/cargo/reference/manifest.html#the-exclude-and-include-fields

@mkaput mkaput added this to Scarb Sep 5, 2023
@mkaput mkaput converted this from a draft issue Sep 5, 2023
@mkaput mkaput added this to the Package registry & new resolver milestone Sep 5, 2023
@mkaput mkaput added the help wanted Extra attention is needed label Sep 18, 2023
mkaput added a commit that referenced this issue Oct 3, 2023
This PR makes `scarb package` check for `.scarbignore` files when determining package source files set. This is a trivial addition thanks to features of the `ignore` crate.

Supporting this file is effectively a similar feature to the include/exclude fields of Cargo (https://doc.rust-lang.org/cargo/reference/manifest.html#the-exclude-and-include-fields). This PR fixes #644 then, as we do not want to create multiple ways of achieving the same thing.

commit-id:3e87fb71
@mkaput mkaput linked a pull request Oct 3, 2023 that will close this issue
@mkaput mkaput removed the help wanted Extra attention is needed label Oct 3, 2023
@mkaput mkaput self-assigned this Oct 3, 2023
@mkaput mkaput moved this from Backlog to In Progress in Scarb Oct 3, 2023
mkaput added a commit that referenced this issue Oct 3, 2023
This PR makes `scarb package` check for `.scarbignore` files when determining package source files set. This is a trivial addition thanks to features of the `ignore` crate.

Supporting this file is effectively a similar feature to the include/exclude fields of Cargo (https://doc.rust-lang.org/cargo/reference/manifest.html#the-exclude-and-include-fields). This PR fixes #644 then, as we do not want to create multiple ways of achieving the same thing.

commit-id:3e87fb71
mkaput added a commit that referenced this issue Oct 3, 2023
This PR makes `scarb package` check for `.scarbignore` files when determining package source files set. This is a trivial addition thanks to features of the `ignore` crate.

Supporting this file is effectively a similar feature to the include/exclude fields of Cargo (https://doc.rust-lang.org/cargo/reference/manifest.html#the-exclude-and-include-fields). This PR fixes #644 then, as we do not want to create multiple ways of achieving the same thing.

commit-id:3e87fb71
github-merge-queue bot pushed a commit that referenced this issue Oct 6, 2023
This PR makes `scarb package` check for `.scarbignore` files when
determining package source files set. This is a trivial addition thanks
to features of the `ignore` crate.

Supporting this file is effectively a similar feature to the
include/exclude fields of Cargo
(https://doc.rust-lang.org/cargo/reference/manifest.html#the-exclude-and-include-fields).
This PR fixes #644 then, as we do not want to create multiple ways of
achieving the same thing.

---

**Stack**:
- #758
- #757
- #748
- #746⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@github-project-automation github-project-automation bot moved this from In Progress to Done in Scarb Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant