Move large struct DetailedTomlDependency into a Box and use Cow to avoid cloning it
#748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2023
Merged
mkaput
force-pushed
the
spr/main/42d7d77a
branch
2 times, most recently
from
6dd1633 to
5ac98b3
Compare
mkaput
force-pushed
the
spr/main/3e87fb71
branch
from
12a7de4 to
c1877a6
Compare
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
5ac98b3 to
8701acc
Compare
maciektr
approved these changes
Oct 5, 2023
mkaput
force-pushed
the
spr/main/3e87fb71
branch
from
c1877a6 to
eeb8d74
Compare
mkaput
force-pushed
the
spr/main/42d7d77a
branch
2 times, most recently
from
09584d9 to
80af4a7
Compare
mkaput
force-pushed
the
spr/main/3e87fb71
branch
2 times, most recently
from
64d5849 to
cf03f9c
Compare
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
80af4a7 to
5960456
Compare
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
5960456 to
e8b8c7b
Compare
mkaput
force-pushed
the
spr/main/3e87fb71
branch
from
a30b337 to
f8e2a60
Compare
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
e8b8c7b to
576f803
Compare
mkaput
force-pushed
the
spr/main/3e87fb71
branch
from
f8e2a60 to
74ff529
Compare
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
576f803 to
2e2f96f
Compare
mkaput
force-pushed
the
spr/main/3e87fb71
branch
from
74ff529 to
214e5b1
Compare
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
2e2f96f to
0088929
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
This PR makes `scarb package` check for `.scarbignore` files when determining package source files set. This is a trivial addition thanks to features of the `ignore` crate. Supporting this file is effectively a similar feature to the include/exclude fields of Cargo (https://doc.rust-lang.org/cargo/reference/manifest.html#the-exclude-and-include-fields). This PR fixes #644 then, as we do not want to create multiple ways of achieving the same thing. --- **Stack**: - #758 - #757 - #748 - #746 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
… to avoid cloning it commit-id:42d7d77a
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
0088929 to
53f898c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
todo!calls in packaging logic #758registryfield to dependency schema #757DetailedTomlDependencyinto aBoxand useCowto avoid cloning it #748 ⬅