Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement normalization of manifests for publishing #710

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Implement normalization of manifests for publishing #710

merged 1 commit into from
Oct 6, 2023

Conversation

mkaput
Copy link
Member

@mkaput mkaput commented Sep 25, 2023 •
edited
Loading

This was referenced Sep 25, 2023
Merged
Merged
Merged
Merged
@mkaput mkaput marked this pull request as draft September 25, 2023 19:45
@mkaput mkaput changed the base branch from spr/main/1b03d139 to main September 26, 2023 10:21
@mkaput mkaput mentioned this pull request Sep 26, 2023
Merged
@mkaput mkaput changed the base branch from main to spr/main/1b03d139 September 26, 2023 10:21
github-merge-queue bot pushed a commit that referenced this pull request Sep 27, 2023
@mkaput
Fix TomlTargetKind parsing rules (#712)
45b936a 
1. There were no reasons to disallow `[[target.lib]]`.
2. On the other hand, it would be cool to expect target names to have
package-name-style validation.

---

**Stack**:
- #697
- #710
- #675
- #657
- #646
- #712 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput force-pushed the spr/main/fa87cc89 branch 2 times, most recently from c5b93fb to 3688e71 Compare September 27, 2023 10:14
@mkaput mkaput force-pushed the spr/main/fa87cc89 branch 2 times, most recently from 89a843c to da7f64a Compare September 27, 2023 17:53
@mkaput mkaput marked this pull request as ready for review September 27, 2023 18:05
@mkaput mkaput requested review from maciektr and szymmis September 27, 2023 18:06
@mkaput mkaput marked this pull request as draft September 27, 2023 18:06
github-merge-queue bot pushed a commit that referenced this pull request Sep 28, 2023
@mkaput
Document package tarballs (#646)
a65393e 
**Stack**:
- #697
- #710
- #675
- #657
- #646 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput changed the base branch from spr/main/1b03d139 to main September 28, 2023 10:39
@mkaput mkaput mentioned this pull request Sep 28, 2023
Merged
@mkaput mkaput changed the base branch from main to spr/main/57e55df8 September 28, 2023 10:39
@mkaput mkaput force-pushed the spr/main/fa87cc89 branch 2 times, most recently from 30f7875 to 3c3ced4 Compare September 28, 2023 12:16
github-merge-queue bot pushed a commit that referenced this pull request Sep 28, 2023
@mkaput
Create actual .tar.zst archive (#675)
e3653ce 
**Stack**:
- #697
- #710
- #726
- #675 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/57e55df8 to main September 28, 2023 12:49
github-merge-queue bot pushed a commit that referenced this pull request Sep 28, 2023
@mkaput
DepBuilder DSL (#726)
d534ab4 
This PR adds a new DSL for specifying dependencies in `ProjectBuilder`
and `WorkspaceBuilder`. It is capable of expressing all cases for which
we have been falling back to strings currently, and also it can now do
things like amending auto-generated deps for e.g. paths.

This PR updates all string- and TOML table-based usages of old API. It
does not migrate explicit paths usage to auto-generation for
`ChildPaths` whereverr we want to ensure paths are properly treated as
relative.

---

**Stack**:
- #697
- #710
- #726 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput mentioned this pull request Oct 3, 2023
Merged
@mkaput mkaput force-pushed the spr/main/fa87cc89 branch from 56e4a56 to 890c2cd Compare October 3, 2023 09:45
This was referenced Oct 3, 2023
Merged
Merged
@mkaput mkaput mentioned this pull request Oct 3, 2023
Merged
@mkaput mkaput force-pushed the spr/main/fa87cc89 branch 2 times, most recently from a267b4d to d86e6df Compare October 5, 2023 08:23
This was referenced Oct 5, 2023
Merged
Merged
@mkaput mkaput force-pushed the spr/main/fa87cc89 branch 2 times, most recently from 326a3af to 4fbbe50 Compare October 6, 2023 08:10
@mkaput mkaput force-pushed the spr/main/fa87cc89 branch from 4fbbe50 to b1a2d72 Compare October 6, 2023 08:58
@mkaput mkaput enabled auto-merge October 6, 2023 08:58
@mkaput mkaput added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit 004d840 Oct 6, 2023
@mkaput mkaput deleted the spr/main/fa87cc89 branch October 6, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szymmis szymmis szymmis approved these changes

@maciektr maciektr maciektr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkaput @maciektr @szymmis