Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffold scarb package command, implementing --list arg #657

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Scaffold scarb package command, implementing --list arg #657

merged 1 commit into from
Sep 28, 2023

Conversation

mkaput
Copy link
Member

@mkaput mkaput commented Sep 8, 2023 •
edited
Loading

@mkaput mkaput mentioned this pull request Sep 8, 2023
Merged
@mkaput mkaput mentioned this pull request Sep 13, 2023
Merged
@mkaput mkaput force-pushed the spr/main/cd0036df branch 2 times, most recently from 531ac2e to f2928e3 Compare September 15, 2023 10:42
@mkaput mkaput mentioned this pull request Sep 22, 2023
Merged
@mkaput mkaput changed the base branch from spr/main/87f8c915 to main September 25, 2023 19:41
This was referenced Sep 25, 2023
Merged
Closed
@mkaput mkaput mentioned this pull request Sep 25, 2023
Closed
@mkaput mkaput changed the base branch from main to spr/main/87f8c915 September 25, 2023 19:41
@mkaput mkaput changed the base branch from spr/main/87f8c915 to main September 25, 2023 19:44
@mkaput mkaput mentioned this pull request Sep 25, 2023
Merged
@mkaput mkaput changed the base branch from main to spr/main/87f8c915 September 25, 2023 19:44
github-merge-queue bot pushed a commit that referenced this pull request Sep 26, 2023
@mkaput
Use UTF-8 paths for source-path field (#707)
66baac7 
**Stack**:
- #709
- #697
- #675
- #657
- #646
- #708
- #707 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput changed the base branch from spr/main/87f8c915 to main September 26, 2023 10:21
@mkaput mkaput mentioned this pull request Sep 26, 2023
Merged
@mkaput mkaput changed the base branch from main to spr/main/87f8c915 September 26, 2023 10:21
github-merge-queue bot pushed a commit that referenced this pull request Sep 27, 2023
@mkaput
Fix TomlTargetKind parsing rules (#712)
45b936a 
1. There were no reasons to disallow `[[target.lib]]`.
2. On the other hand, it would be cool to expect target names to have
package-name-style validation.

---

**Stack**:
- #697
- #710
- #675
- #657
- #646
- #712 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput force-pushed the spr/main/cd0036df branch 2 times, most recently from 2970b9c to 655a824 Compare September 27, 2023 18:04
@mkaput mkaput marked this pull request as ready for review September 27, 2023 18:04
@mkaput mkaput requested review from maciektr and szymmis September 27, 2023 18:05
github-merge-queue bot pushed a commit that referenced this pull request Sep 28, 2023
@mkaput
Document package tarballs (#646)
a65393e 
**Stack**:
- #697
- #710
- #675
- #657
- #646 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/87f8c915 to main September 28, 2023 10:01
maciektr
maciektr approved these changes Sep 28, 2023
View reviewed changes
scarb/src/ops/package.rs Outdated Show resolved Hide resolved
@mkaput mkaput mentioned this pull request Sep 28, 2023
Merged
@mkaput mkaput enabled auto-merge September 28, 2023 10:39
@mkaput mkaput added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit d588942 Sep 28, 2023
@mkaput mkaput deleted the spr/main/cd0036df branch September 28, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szymmis szymmis szymmis approved these changes

@maciektr maciektr maciektr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkaput @maciektr @szymmis