Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy PackagesFilter into scarb-ui #583

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Copy PackagesFilter into scarb-ui #583

merged 1 commit into from
Aug 22, 2023

Conversation

mkaput
Copy link
Member

@mkaput mkaput commented Aug 18, 2023 •
edited
Loading

  • The subsequent commit will deprecate original struct in scarb-metadata
  • The new version uses anyhow instead of thiserror
  • Some error messages were updated to follow help: convention

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Aug 18, 2023
Merged
Merged
Merged
@mkaput mkaput requested a review from maciektr August 18, 2023 09:52
@mkaput mkaput marked this pull request as ready for review August 18, 2023 09:52
This was referenced Aug 18, 2023
Merged
Closed
@mkaput mkaput force-pushed the spr/main/e8028ba6 branch from 8b28ff6 to 4431291 Compare August 18, 2023 12:43
@mkaput mkaput force-pushed the spr/main/9f7030be branch from 34e2619 to 93a185d Compare August 18, 2023 12:43
@mkaput mkaput mentioned this pull request Aug 18, 2023
Merged
Base automatically changed from spr/main/9f7030be to main August 18, 2023 13:14
@mkaput
Copy PackagesFilter into scarb-ui
8c62fda 
- The subsequent commit will deprecate original struct in `scarb-metadata`
- The new version uses `anyhow` instead of `thiserror`
- Some error messages were updated to follow `help:` convention

commit-id:e8028ba6
@mkaput mkaput force-pushed the spr/main/e8028ba6 branch from 4431291 to 8c62fda Compare August 18, 2023 17:38
@mkaput mkaput added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit d98fca8 Aug 22, 2023
@mkaput mkaput deleted the spr/main/e8028ba6 branch August 22, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr maciektr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkaput @maciektr