Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly use Status message when testing workspace #585

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Properly use Status message when testing workspace #585

merged 1 commit into from
Aug 22, 2023

Conversation

mkaput
Copy link
Member

@mkaput mkaput commented Aug 18, 2023 •
edited
Loading

  • Status should always be a single verb.
  • Print what command is going to be called, like Cargo does

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Aug 18, 2023
Closed
Merged
Merged
Merged
@mkaput mkaput marked this pull request as ready for review August 18, 2023 12:43
@mkaput mkaput requested a review from maciektr August 18, 2023 12:44
@mkaput mkaput mentioned this pull request Aug 18, 2023
Merged
@mkaput mkaput force-pushed the spr/main/389fc6bc branch from 9e3e226 to c183d11 Compare August 18, 2023 17:38
@mkaput mkaput force-pushed the spr/main/9877aa8b branch from 0e9b951 to 11db5de Compare August 18, 2023 17:38
@mkaput mkaput force-pushed the spr/main/389fc6bc branch from c183d11 to b892e65 Compare August 22, 2023 11:12
@mkaput mkaput force-pushed the spr/main/9877aa8b branch from 11db5de to 84e368f Compare August 22, 2023 11:12
Base automatically changed from spr/main/389fc6bc to main August 22, 2023 11:39
@mkaput mkaput force-pushed the spr/main/9877aa8b branch from 84e368f to a5a36ea Compare August 22, 2023 11:43
@mkaput
Properly use Status message when testing workspace
11772f9 
- Status should always be a single verb.
- Print what command is going to be called, like Cargo does

commit-id:9877aa8b
@mkaput mkaput force-pushed the spr/main/9877aa8b branch from a5a36ea to 11772f9 Compare August 22, 2023 11:45
@mkaput mkaput enabled auto-merge August 22, 2023 11:45
@mkaput mkaput added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit 7f866d5 Aug 22, 2023
@mkaput mkaput deleted the spr/main/9877aa8b branch August 22, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr maciektr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkaput @maciektr