Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 0.4.0 #197

Merged
merged 29 commits into from
Jan 12, 2023
Merged

Milestone 0.4.0 #197

merged 29 commits into from
Jan 12, 2023

Conversation

cptartur
Copy link
Member

@cptartur cptartur commented Nov 24, 2022

Describe your changes

Linked issues

Closes

Breaking changes

  • This issue contains breaking changes

@cptartur cptartur added this to the 0.4.0 milestone Nov 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Base: 69.56% // Head: 70.19% // Increases project coverage by +0.62% 🎉

Coverage data is based on head (5068c94) compared to base (874764b).
Patch coverage: 56.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   69.56%   70.19%   +0.62%     
==========================================
  Files          53       58       +5     
  Lines        1564     1778     +214     
  Branches      111      118       +7     
==========================================
+ Hits         1088     1248     +160     
- Misses        446      492      +46     
- Partials       30       38       +8     
Impacted Files Coverage Δ
...n/kotlin/com/swmansion/starknet/account/Account.kt 100.00% <ø> (ø)
...tlin/com/swmansion/starknet/crypto/NativeLoader.kt 29.03% <0.00%> (ø)
...m/swmansion/starknet/service/http/OkHttpService.kt 51.85% <0.00%> (ø)
...lin/com/swmansion/starknet/data/types/Responses.kt 25.42% <4.22%> (-22.12%) ⬇️
...knet/data/types/transactions/TransactionReceipt.kt 22.22% <9.67%> (+5.40%) ⬆️
...on/starknet/data/types/transactions/Transaction.kt 62.85% <25.53%> (-10.77%) ⬇️
.../kotlin/com/swmansion/starknet/data/types/Event.kt 31.57% <33.33%> (+1.57%) ⬆️
...kotlin/com/swmansion/starknet/provider/Provider.kt 28.57% <33.33%> (+8.57%) ⬆️
...lin/com/swmansion/starknet/data/types/Contracts.kt 49.35% <39.28%> (+6.95%) ⬆️
.../JsonRpcTransactionReceiptPolymorphicSerializer.kt 41.66% <42.85%> (-8.34%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cptartur
Copy link
Member Author

Before merging, replace the RequestFailedException in the OkHttpProvider with a custom, unchecked exception indicating that the error was caused by network problems (to differentiate between this and StarkNet level errors).

@THenry14 THenry14 marked this pull request as ready for review January 12, 2023 12:33
@THenry14 THenry14 merged commit f12cd80 into main Jan 12, 2023
@DelevoXDG DelevoXDG mentioned this pull request Feb 5, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants