RPC 0.6.0 cleanup #381
Merged
RPC 0.6.0 cleanup #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… correctly handled by networks
DelevoXDG
force-pushed
the
rpc-0.6.0-cleanup
branch
from
76099bc
to
09e24da
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
+ Coverage 67.64% 69.29% +1.65%
==========================================
Files 72 72
Lines 3171 3127 -44
Branches 322 315 -7
==========================================
+ Hits 2145 2167 +22
+ Misses 863 810 -53
+ Partials 163 150 -13 ☔ View full report in Codecov by Sentry. |
…ateTransactionsTest
- SEPOLIA_TESTNET -> SEPOLIA - SEPOLIA_INTEGRATION -> INTEGRATION_SEPOLIA
DelevoXDG
commented
Jan 31, 2024
Comment on lines
-213
to
-217
| tip = tip, | ||
| paymasterData = paymasterData, | ||
| accountDeploymentData = accountDeploymentData, | ||
| nonceDataAvailabilityMode = nonceDataAvailabilityMode, | ||
| feeDataAvailabilityMode = feeDataAvailabilityMode, |
There was a problem hiding this comment.
Should we also make primary constructor private similarly to TransactionPayload, v3 params and so on, and create constructor with hardcoded fields? I decided to not do it for now:
- to not further clutter the PR
- because there were previously some non-rpc fields and we didn't hardcode anything
- we mainly use
TransactionFactoryto correctly createTransactionobjects anyway
This would be easily solved with #394, but we decided to do it separately.
DelevoXDG
commented
Jan 31, 2024
lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/TransactionPayload.kt
Show resolved
Hide resolved
THenry14
reviewed
Feb 5, 2024
| @@ -146,21 +170,6 @@ data class InvokeTransactionV1( | |||
| version = version, | |||
| ) | |||
| } | |||
|
|
|||
| companion object { | |||
There was a problem hiding this comment.
We don't use it anywhere, I'm not sure if we ever did use it. I couldn't find it being used in #197 (PR where it was added). Since this is an internal method and we don't use it anywhere internally, I don't think we need it.
Comment on lines
-213
to
-217
| tip = tip, | ||
| paymasterData = paymasterData, | ||
| accountDeploymentData = accountDeploymentData, | ||
| nonceDataAvailabilityMode = nonceDataAvailabilityMode, | ||
| feeDataAvailabilityMode = feeDataAvailabilityMode, |
lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/TransactionPayload.kt
Show resolved
Hide resolved
Comment on lines
-39
to
+36
| @Serializable(with = JsonRpcStandardErrorSerializer::class) | ||
| internal data class JsonRpcStandardError( | ||
| @SerialName("code") | ||
| override val code: Int, | ||
|
|
||
| @SerialName("message") | ||
| override val message: String, | ||
|
|
||
| @SerialName("data") | ||
| override val data: String? = null, | ||
| ) : JsonRpcError() | ||
|
|
||
| @Serializable | ||
| internal data class JsonRpcContractError( | ||
| @SerialName("code") | ||
| override val code: Int, | ||
|
|
||
| @SerialName("message") | ||
| override val message: String, | ||
|
|
||
| @SerialName("data") | ||
| override val data: JsonRpcContractErrorData, | ||
| ) : JsonRpcError() | ||
|
|
||
| @Serializable | ||
| internal data class JsonRpcContractErrorData( | ||
| @SerialName("revert_error") | ||
| val revertError: String, | ||
| ) { | ||
| override fun toString(): String { | ||
| return revertError | ||
| } | ||
| } | ||
| val data: String? = null, | ||
| ) |
There was a problem hiding this comment.
what is this change related to?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Refactoring and cleanup post #358. Includes missing transaction v3 functionalities, more streamlined interface, bug fixes and tests covering Starknet 0.13 features.
Account,StandardAccountV1,V2,V3postfixes respectivelyestimateFeeV(1|3)no longer acceptsSet<SimulationFlagForEstimateFee>, instead takesskipValidate: BoolestimateFeeV3(Call)executeV3estimates incorrect fee #396Deployer,StandardDeployer: AdddeployContractV3methods ; renamedeployContract->deployContractV1ExecutionParamsV3->InvokeParamsV3TransactionPayload: make primary constructor private; add custom constructor with hardcoded valuesTransactionFactory: don't accept v3 transaction paramsDeprecatedTransactionandTransactionV3interfacesStarknetChainId: RenameSEPOLIA_TESTNET->SEPOLIA, renamedSEPOLIA_INTEGRATOIN->INTEGATION_SEPOLIA(should we remove enum altogether?)TransactionHashCalculator: test v3s; add missing declare v1/v2 testsFeltTests->NumAsHexBaseTests; test all numbers; nest Felt-specific tests; add Uint256 tetsStandardAccountTestDeclareEstimateTest,DeclareTests,DeployAccountEstimateTest,DeployAccountTest,DeployAccountEstimateTestsimulateTransactions,estimateFee)SKIP_VALIDATEtestStandardDeployerTest: test deploy v3contract_with_constructor.cairo(no longer used in tests)Linked issues
Closes #402
Closes #372
Closes #393
Closes #395
Closes #396
Closes #374
Breaking changes
Account,StandardAccount: all methods that have v1, v2 and v3 variants now haveV1,V2,V3postfixes respectivelyDeployer,StandardDeployer:deployContractsplit intodeployContractV1anddeployContractV3estimateFeeV(1|3)no longer acceptsSet<SimulationFlagForEstimateFee>, instead takesskipValidate: Booltip,paymasterData,accountDeploymentData,nonceDataAvailabilityMode,feeDataAvailabilityMode) fromTransactionPayloadconstructorstip,paymasterData,accountDeploymentData,nonceDataAvailabilityMode,feeDataAvailabilityMode) fromTransactionFactorymethodsExecutionParamsV3->InvokeParamsV3StarknetChainId: RenamedSEPOLIA_TESTNET->SEPOLIA, renamedSEPOLIA_INTEGRATOIN->INTEGATION_SEPOLIA,