Fix: remove fs.readFileSync from genesis hash test #1521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
approved these changes
Aug 10, 2023
Contributor
buffalojoec
left a comment
buffalojoec
left a comment
There was a problem hiding this comment.
Solid fix mate, nicely done
We instead use a read stream to process the file in chunks
mcintyre94
force-pushed
the
genesis-hash-fixup
branch
from
07f8500 to
8c1a959
Compare
Contributor
|
🎉 This PR is included in version 1.78.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We instead use a read stream to process the file in chunks
This avoids a bug where when validator.log gets too big locally the
fs.readFileSyncwould failFixes #1517