Skip to content

Fix: remove fs.readFileSync from genesis hash test #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcintyre94 merged 1 commit into from
Aug 10, 2023
Merged

Fix: remove fs.readFileSync from genesis hash test #1521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions packages/rpc-core/src/rpc-methods/__tests__/get-genesis-hash-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,24 @@ import { createSolanaRpcApi, SolanaRpcMethods } from '../index';
const logFilePath = path.resolve(__dirname, '../../../../../test-ledger/validator.log');
const genesisHashPattern = /genesis hash: ([\d\w]{32,})/;

async function getGenesisHashFromLogFile() {
return new Promise<string | undefined>((resolve, reject) => {
const logFileStream = fs.createReadStream(logFilePath, { end: 64 * 1024 });
logFileStream.on('error', e => reject(e))

logFileStream.on('data', data => {
const chunk = data.toString('utf-8');
const expectedGenesisHash = chunk.match(genesisHashPattern)?.[1];
if (expectedGenesisHash) {
logFileStream.destroy();
resolve(expectedGenesisHash)
}
})

logFileStream.on('end', () => resolve(undefined));
})
}

describe('getGenesisHash', () => {
let rpc: Rpc<SolanaRpcMethods>;
beforeEach(() => {
Expand All @@ -23,8 +41,7 @@ describe('getGenesisHash', () => {
describe('when sent to a local validator', () => {
it('returns the genesis hash', async () => {
expect.assertions(1);
const logFile = fs.readFileSync(logFilePath, 'utf-8');
const expectedGenesisHash = logFile.match(genesisHashPattern)?.[1];
const expectedGenesisHash = await getGenesisHashFromLogFile();
const genesisHashPromise = rpc.getGenesisHash().send();
await expect(genesisHashPromise).resolves.toBe(expectedGenesisHash);
});
Expand Down