stake-pool: Align types to 1 for safe pointer cast #5179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to unblock the monorepo |
joncinque
changed the title
thlorenz
added a commit
to ironforge-cloud/solana-program-library
that referenced
this pull request
Sep 4, 2023
* master: (719 commits) release: Bump token-2022 and all dependencies (solana-labs#5189) SPL errors from hashes (solana-labs#5169) stake-pool: Add comments about unnecessary ownership checks (HAL-01) (solana-labs#5084) stake-pool: Enforce that pool mint uses 9 decimal places (HAL-03) (solana-labs#5085) build(deps-dev): bump tsx from 3.12.7 to 3.12.8 in /single-pool/js (solana-labs#5188) account-compression: Fixup sdk doc deployment (solana-labs#5187) token-js: renamed `getExtraAccountMetaAccount` to `getExtraAccountMetaAddress` (solana-labs#5186) token-js: added an e2e test for transferring using a mint with a transfer hook extension (solana-labs#5138) Serde optional dependencies clean-up (solana-labs#5181) build(deps): bump chrono from 0.4.27 to 0.4.28 (solana-labs#5180) stake-pool: Use unaligned types for safe pointer cast (solana-labs#5179) spl-pod: make code docs more explicit (solana-labs#5178) token-js: added extra account resolution for transfer hook extension (solana-labs#5112) Fix incorrect code doc (solana-labs#5177) Move Pod types to separate library (solana-labs#5119) build(deps-dev): bump @typescript-eslint/eslint-plugin from 6.4.1 to 6.5.0 in /memo/js (solana-labs#5176) build(deps): bump chrono from 0.4.26 to 0.4.27 (solana-labs#5171) build(deps-dev): bump prettier from 3.0.2 to 3.0.3 in /token-swap/js (solana-labs#5174) build(deps-dev): bump prettier from 3.0.2 to 3.0.3 in /token/js (solana-labs#5172) build(deps-dev): bump prettier from 3.0.2 to 3.0.3 in /token-lending/js (solana-labs#5173) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Under Rust 1.72, the cast done by the stake pool program from raw bytes into a
ValidatorStakeInfopanics because the underlying pointer might not be aligned to an address with a multiple of 8. See the offending line: https://github.com/solana-labs/solana-program-library/blob/c79c727f88710e565cd47bde0049f1b449aef0eb/stake-pool/program/src/big_vec.rs#L163C1-L163C80And see https://github.com/solana-labs/solana/actions/runs/6029425589/job/16358927677?pr=32961 for a failing run.
Solution
It causes loads of churn, but do the right thing: use the alignment-safe
PodU64andPodU32instead ofu64andu32, respectively.Note: this is blocking the upgrade of the monorepo to 1.72 because of downstream build errors