Upgrades Rust to 1.72.0 & nightly-2023-08-25 #32961

Lichtso · 2023-08-23T20:21:44Z

Upgrade the rust (stable) toolchain to 1.72.0

https://blog.rust-lang.org/2023/06/01/Rust-1.70.0.html
https://blog.rust-lang.org/2023/07/13/Rust-1.71.0.html
https://blog.rust-lang.org/2023/08/24/Rust-1.72.0.html

brooksprumo · 2023-08-23T20:25:04Z

Rust 1.72.0 is schedule to be released tomorrow, any interest in waiting a day and going all the way to 1.72.0 instead?

I think I tired upgrading to 1.71.0 when it was first released; iirc there was a clippy bug that is supposed to be fixed in 1.72.0. Let me see if I can find more information.

Lichtso · 2023-08-23T20:32:01Z

This will give us OnceCell which can mostly replace lazy_static.

brooksprumo · 2023-08-23T20:32:46Z

I think I tired upgrading to 1.71.0 when it was first released; iirc there was a clippy bug that is supposed to be fixed in 1.72.0. Let me see if I can find more information.

Maybe the clippy bug I was thinking about was fixed in 1.71.0? Here's more context: https://discord.com/channels/428295358100013066/832013492239990805/1117251668141154424

brooksprumo · 2023-08-23T20:36:08Z

By chance have you already tried checks locally with 1.72.0 from beta/nightly? I would imagine there are new clippy lints to deal with.

brooksprumo · 2023-08-23T20:38:08Z

@yihau Flagging this PR for you. Tomorrow when Rust 1.72.0 is released, can the CI image be updated with this new version?

Lichtso · 2023-08-23T20:39:35Z

No have not tried 1.72.0, only 1.71.0
If it is too much work, we can revert this PR back to 1.71.0

brooksprumo · 2023-08-24T13:15:21Z

No have not tried 1.72.0, only 1.71.0 If it is too much work, we can revert this PR back to 1.71.0

If we need to revert, can we use 1.71.1 instead of 1.71.0?
https://blog.rust-lang.org/2023/08/03/Rust-1.71.1.html

brooksprumo · 2023-08-24T13:50:39Z

@yihau Ok, Rust 1.72.0 has been released!
https://blog.rust-lang.org/2023/08/24/Rust-1.72.0.html

yihau · 2023-08-24T13:57:28Z

yeah but it seems that they haven't uploaded the docker image. maybe need some time 😢

brooksprumo

Overall looks good.

For anyone wondering about the integer_arithmetic -> arithmetic_side_effects, it was renamed. See this page for more info: https://rust-lang.github.io/rust-clippy/master/index.html#/arithmetic_side_effects

sdk/src/transaction_context.rs

Lichtso · 2023-08-24T17:32:59Z

I think we should split this into multiple PRs, just trying to gather what is required in total here.

yihau · 2023-08-25T04:31:39Z

just updated docker images 🐳 and re-run your pipeline. it seems to be blocked on this error atm

ryoqun · 2023-08-31T15:27:55Z

sadly, it's my sleep time! please merge or fix more if ci fails further after the currently running one...

brooksprumo · 2023-08-31T15:53:37Z

bucket_map/src/bucket_storage.rs

+    // rust 1.73+ (our as-of-writing nightly version) changed panic message. we're stuck with this
+    // short common substring until the monorepo is fully 1.73+ including stable.
+    #[should_panic(expected = "left == right")]


FYI I'm fixing this here: #33091
Edit: Merged.

* remove dubious test

…s false.

codecov · 2023-09-01T07:26:14Z

Codecov Report

Merging #32961 (310e6e8) into master (4fe0812) will increase coverage by 0.1%.
Report is 1 commits behind head on master.
The diff coverage is 95.5%.

@@            Coverage Diff            @@
##           master   #32961     +/-   ##
=========================================
+ Coverage    81.9%    82.1%   +0.1%     
=========================================
  Files         785      785             
  Lines      213430   211171   -2259     
=========================================
- Hits       174938   173385   -1553     
+ Misses      38492    37786    -706

:Release Notes: After rust upgrade in oe-core from 1.71.1 to 1.74.1 in: https://git.openembedded.org/openembedded-core/commit/?id=30637cdeb31fae02544fdc643a455d0ebb126ee6 and following commits, solana was failing to build. :Detailed Notes: Backport a fix from v1.17.0: solana-labs/solana#32961 we need only this part: solana-labs/solana@9e703f8#diff-2830a98fa15197faaaf1226883e9011c9302fedb10c7926077b17c07fa320c57 for other fixes we should just upgrade solana in OSE to latest. :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRP-29491] Create GPVB with Yocto 5.0 Scarthgap Change-Id: I4b926d3da35a3f2341593f19bb1332b233fc2c2a

:Release Notes: After rust upgrade in oe-core from 1.71.1 to 1.74.1 in: https://git.openembedded.org/openembedded-core/commit/?id=30637cdeb31fae02544fdc643a455d0ebb126ee6 and following commits, solana was failing to build. :Detailed Notes: Backport a fix from v1.17.0: solana-labs/solana#32961 we need only this part: solana-labs/solana@9e703f8#diff-2830a98fa15197faaaf1226883e9011c9302fedb10c7926077b17c07fa320c57 for other fixes we should just upgrade solana in OSE to latest. :Testing Performed: Only build tested. :QA Notes: No change to image. :Issues Addressed: [WRQ-9293] CCC: solana: Fix build with rust-1.72 and newer [WRP-29491] Create GPVB with Yocto 5.0 Scarthgap Cherry-picked-from-commit: 76222be Cherry-picked-from-branch:

Lichtso requested a review from brooksprumo August 23, 2023 20:21

Lichtso changed the title ~~Upgrades Rust to 1.71.0~~ Upgrades Rust to 1.72.0 Aug 23, 2023

Lichtso force-pushed the rust/v1.71.0 branch from 5dca8c3 to ce2a22b Compare August 23, 2023 20:30

Lichtso force-pushed the rust/v1.71.0 branch 2 times, most recently from 1505fd9 to a40e03c Compare August 24, 2023 16:03

apfitzge self-requested a review August 24, 2023 16:28

brooksprumo reviewed Aug 24, 2023

View reviewed changes

sdk/src/transaction_context.rs Outdated Show resolved Hide resolved

Lichtso force-pushed the rust/v1.71.0 branch from a40e03c to 6e3dfc8 Compare August 24, 2023 17:29

Lichtso force-pushed the rust/v1.71.0 branch from 6e3dfc8 to 4694575 Compare August 24, 2023 17:44

Lichtso mentioned this pull request Aug 24, 2023

General cleanup #32980

Merged

Lichtso force-pushed the rust/v1.71.0 branch from 4694575 to 1e0ef1a Compare August 24, 2023 19:52

Lichtso mentioned this pull request Aug 24, 2023

Refactor - Demotes Arc to Rc. #32982

Merged

apfitzge mentioned this pull request Aug 24, 2023

Do not derive Copy for EpochSchedule and Rent #32767

Merged

Lichtso mentioned this pull request Aug 24, 2023

CI - Disables Downstream Project actions #32983

Merged

Lichtso force-pushed the rust/v1.71.0 branch from 1e0ef1a to 8eef723 Compare August 24, 2023 23:02

This was referenced Aug 25, 2023

General cleanup (Part 2) #32998

Merged

Fix - Upcoming arithmetic_side_effects lints #33000

Merged

t-nelson mentioned this pull request Aug 29, 2023

bump nightly to 2023-08-25 #33048

Closed

Lichtso force-pushed the rust/v1.71.0 branch from 8eef723 to 017df02 Compare August 29, 2023 19:06

ryoqun changed the title ~~Upgrades Rust to 1.72.0+nightly-2023-08-25~~ Upgrades Rust to 1.72.0 & nightly-2023-08-25 Aug 31, 2023

brooksprumo mentioned this pull request Aug 31, 2023

Refactor bucket storage bad header size test #33091

Merged

brooksprumo reviewed Aug 31, 2023

View reviewed changes

t-nelson force-pushed the rust/v1.71.0 branch from bf73572 to d74f293 Compare September 1, 2023 00:25

ryoqun mentioned this pull request Sep 1, 2023

Make should_panic tests compatible with 1.73+ panic format #33099

Merged

t-nelson added 3 commits August 31, 2023 20:05

allow pedantic invalid cast lint

cc1bf78

allow lint with false-positive triggered by test-case crate

5b6aaa4

nightly fmt correction

36c1740

t-nelson force-pushed the rust/v1.71.0 branch from d74f293 to 2d937a7 Compare September 1, 2023 02:05

adapt to rust layout changes

4d47602

* remove dubious test

t-nelson force-pushed the rust/v1.71.0 branch from 2d937a7 to 85e7cc4 Compare September 1, 2023 02:50

Lichtso and others added 3 commits August 31, 2023 23:03

Use transmute instead of pointer cast and de/ref when check_aligned i…

21df019

…s false.

Renames clippy::integer_arithmetic to clippy::arithmetic_side_effects.

320b3a0

bump rust nightly to 2023-08-25

828e4ea

t-nelson force-pushed the rust/v1.71.0 branch from 85e7cc4 to 937f2a1 Compare September 1, 2023 05:03

t-nelson added the CI Pull Request is ready to enter CI label Sep 1, 2023

solana-grimes removed the CI Pull Request is ready to enter CI label Sep 1, 2023

t-nelson force-pushed the rust/v1.71.0 branch from 937f2a1 to 11c911b Compare September 1, 2023 05:30

Upgrades Rust to 1.72.0

310e6e8

t-nelson force-pushed the rust/v1.71.0 branch from 11c911b to 310e6e8 Compare September 1, 2023 06:01

ilya-bobyr approved these changes Sep 1, 2023

View reviewed changes

Lichtso added the automerge Merge this Pull Request automatically once CI passes label Sep 1, 2023

mergify bot merged commit 9e703f8 into master Sep 1, 2023

mergify bot deleted the rust/v1.71.0 branch September 1, 2023 07:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrades Rust to 1.72.0 & nightly-2023-08-25 #32961

Upgrades Rust to 1.72.0 & nightly-2023-08-25 #32961

Lichtso commented Aug 23, 2023 •

edited

Loading

brooksprumo commented Aug 23, 2023

Lichtso commented Aug 23, 2023

brooksprumo commented Aug 23, 2023

brooksprumo commented Aug 23, 2023

brooksprumo commented Aug 23, 2023

Lichtso commented Aug 23, 2023

brooksprumo commented Aug 24, 2023

brooksprumo commented Aug 24, 2023

yihau commented Aug 24, 2023

brooksprumo left a comment

Lichtso commented Aug 24, 2023

yihau commented Aug 25, 2023 •

edited

Loading

ryoqun commented Aug 31, 2023

brooksprumo Aug 31, 2023 •

edited

Loading

codecov bot commented Sep 1, 2023

Upgrades Rust to 1.72.0 & nightly-2023-08-25 #32961

Upgrades Rust to 1.72.0 & nightly-2023-08-25 #32961

Conversation

Lichtso commented Aug 23, 2023 • edited Loading

brooksprumo commented Aug 23, 2023

Lichtso commented Aug 23, 2023

brooksprumo commented Aug 23, 2023

brooksprumo commented Aug 23, 2023

brooksprumo commented Aug 23, 2023

Lichtso commented Aug 23, 2023

brooksprumo commented Aug 24, 2023

brooksprumo commented Aug 24, 2023

yihau commented Aug 24, 2023

brooksprumo left a comment

Choose a reason for hiding this comment

Lichtso commented Aug 24, 2023

yihau commented Aug 25, 2023 • edited Loading

ryoqun commented Aug 31, 2023

brooksprumo Aug 31, 2023 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Sep 1, 2023

Codecov Report

Lichtso commented Aug 23, 2023 •

edited

Loading

yihau commented Aug 25, 2023 •

edited

Loading

brooksprumo Aug 31, 2023 •

edited

Loading