Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make should_panic tests compatible with 1.73+ panic format #33099

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

ryoqun
Copy link
Member

@ryoqun ryoqun commented Sep 1, 2023

tldr: rust 1.73 changed panic message format, and some of tests depended on it. update them to work with both <1.73 and >1.73.

split off from #32961 as this isn't strictly coupled with the rust update pr.

@ryoqun ryoqun requested a review from t-nelson September 1, 2023 01:01
@ryoqun ryoqun changed the title 1.73 panic fmt Make should_panic tests compatible 1.73+ panic format Sep 1, 2023
@ryoqun ryoqun changed the title Make should_panic tests compatible 1.73+ panic format Make should_panic tests compatible with 1.73+ panic format Sep 1, 2023
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! :shipit:

@ryoqun ryoqun added the automerge Merge this Pull Request automatically once CI passes label Sep 1, 2023
@mergify mergify bot merged commit 4fe0812 into solana-labs:master Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants