Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

refactor(experimental): make RPC methods extend IRpcApiMethods #1843

Merged
merged 1 commit into from
Dec 12, 2023
Merged

refactor(experimental): make RPC methods extend IRpcApiMethods #1843

merged 1 commit into from
Dec 12, 2023

Conversation

buffalojoec
Copy link
Contributor

This PR adds a type for RpcApiMethods and ensures all RPC methods defined in
@solana/rpc-core extend this type.

This relationship will allow use of these RPC method interfaces in our generic
createJsonRpcApi(..) function (next commit).

@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Nov 14, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Nov 14, 2023
Merged
Merged
Merged
@mergify mergify bot added the community label Nov 14, 2023
@buffalojoec buffalojoec force-pushed the 11-14-refactor_experimental_make_RPC_methods_extend_IRpcApiMethods_ branch 2 times, most recently from e729d1d to d619bc8 Compare November 14, 2023 16:28
@buffalojoec buffalojoec mentioned this pull request Nov 15, 2023
Merged
@buffalojoec buffalojoec force-pushed the 11-14-refactor_experimental_make_RPC_methods_extend_IRpcApiMethods_ branch from d619bc8 to 90176f6 Compare November 15, 2023 20:33
@github-actions github-actions bot added the stale label Dec 7, 2023
@buffalojoec buffalojoec added do-not-close Add this tag to exempt an issue/PR from being closed by the stalebot and removed stale labels Dec 10, 2023
@buffalojoec buffalojoec force-pushed the 11-14-refactor_experimental_make_RPC_methods_extend_IRpcApiMethods_ branch from 90176f6 to 2ed7311 Compare December 10, 2023 14:15
steveluscher
steveluscher approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8900l5.jpg

@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Dec 12, 2023 •
edited
Loading

Merge activity

@buffalojoec buffalojoec merged commit c144a41 into master Dec 12, 2023
6 checks passed
@buffalojoec buffalojoec deleted the 11-14-refactor_experimental_make_RPC_methods_extend_IRpcApiMethods_ branch December 12, 2023 01:32
@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveluscher steveluscher steveluscher approved these changes

@lorisleiva lorisleiva Awaiting requested review from lorisleiva

Assignees
No one assigned
Labels
community do-not-close Add this tag to exempt an issue/PR from being closed by the stalebot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buffalojoec @steveluscher @lorisleiva