Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(experimental): remove UnixTimestamp from allowed numerical values #3120

Merged
merged 1 commit into from
Aug 27, 2024
Merged

refactor(experimental): remove UnixTimestamp from allowed numerical values #3120

merged 1 commit into from
Aug 27, 2024

Conversation

buffalojoec
Copy link
Contributor

@buffalojoec buffalojoec commented Aug 20, 2024 •
edited
Loading

The point of this stack is to make UnixTimestamp a bigint, therefore it's no longer required to be permitted as number. See #3121.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 25f03b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Aug 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @buffalojoec and the rest of your teammates on Graphite Graphite

This was referenced Aug 20, 2024
Merged
Merged
@buffalojoec buffalojoec marked this pull request as ready for review August 20, 2024 18:56
@steveluscher steveluscher linked an issue Aug 21, 2024 that may be closed by this pull request
blockTime is typed as number but it is bigint in API response #3114
Closed
steveluscher
steveluscher approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

This was referenced Aug 21, 2024
Merged
Merged
Merged
@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Aug 27, 2024 •
edited
Loading

Merge activity

  • Aug 27, 3:50 PM EDT: @buffalojoec started a stack merge that includes this pull request via Graphite.
  • Aug 27, 3:51 PM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 27, 3:51 PM EDT: @buffalojoec merged this pull request with Graphite.

@buffalojoec buffalojoec force-pushed the 08-20-refactor_experimental_remove_unixtimestamp_from_allowed_numerical_values branch from 40e928b to 25f03b1 Compare August 27, 2024 19:50
@buffalojoec buffalojoec merged commit 4fa1723 into master Aug 27, 2024
6 checks passed
@buffalojoec buffalojoec deleted the 08-20-refactor_experimental_remove_unixtimestamp_from_allowed_numerical_values branch August 27, 2024 19:51
@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcintyre94 mcintyre94 mcintyre94 approved these changes

@steveluscher steveluscher steveluscher approved these changes

@lorisleiva lorisleiva Awaiting requested review from lorisleiva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blockTime is typed as number but it is bigint in API response
3 participants
@buffalojoec @steveluscher @mcintyre94