Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(experimental): changeset for unix timestamp bigint changes #3134

Conversation

buffalojoec
Copy link
Contributor

@buffalojoec buffalojoec commented Aug 21, 2024

I have no idea if this changeset makes sense with the release candidate, but I felt like this was at least a minor (breaking) change.

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 7126ead

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lorisleiva
Copy link
Contributor

I think because we are in RC, patch is what we need as it'll bump rc.1 to rc.2 which is a breaking change anyway.

@buffalojoec
Copy link
Contributor Author

I think because we are in RC, patch is what we need as it'll bump rc.1 to rc.2 which is a breaking change anyway.

Alrighty, I've changed to patch!

@buffalojoec buffalojoec force-pushed the 08-21-refactor_experimental_changeset_for_unix_timestamp_bigint_changes branch from 5675a25 to a690328 Compare August 23, 2024 17:18
Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

Copy link
Contributor Author

buffalojoec commented Aug 27, 2024

Merge activity

  • Aug 27, 3:50 PM EDT: @buffalojoec started a stack merge that includes this pull request via Graphite.
  • Aug 27, 4:05 PM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 27, 4:06 PM EDT: @buffalojoec merged this pull request with Graphite.

@buffalojoec buffalojoec changed the base branch from 08-21-refactor_experimental_sysvars_update_clock_to_use_unixtimestampunsafebeyond2pow53minus1_ to graphite-base/3134 August 27, 2024 20:01
@buffalojoec buffalojoec changed the base branch from graphite-base/3134 to master August 27, 2024 20:04
@buffalojoec buffalojoec force-pushed the 08-21-refactor_experimental_changeset_for_unix_timestamp_bigint_changes branch from a690328 to 7126ead Compare August 27, 2024 20:04
@buffalojoec buffalojoec merged commit 38faba0 into master Aug 27, 2024
7 checks passed
@buffalojoec buffalojoec deleted the 08-21-refactor_experimental_changeset_for_unix_timestamp_bigint_changes branch August 27, 2024 20:06
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants