Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getClusterNodes response #3201

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

lorisleiva
Copy link
Contributor

@lorisleiva lorisleiva commented Sep 3, 2024

This PR updates the response's type and test expectations of the getClusterNodes RPC method to keep it in sync with the latest RPC changes.

See anza-xyz/agave#1637

Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: ec49a81

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lorisleiva lorisleiva marked this pull request as ready for review September 3, 2024 22:02
Copy link
Contributor

@mcintyre94 mcintyre94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor Author

lorisleiva commented Sep 5, 2024

Merge activity

@lorisleiva lorisleiva merged commit 02cefa7 into master Sep 5, 2024
9 checks passed
@lorisleiva lorisleiva deleted the loris/update-get-cluster-nodes branch September 5, 2024 09:19
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants