Fixing misnamed field in PerformanceSample return type

[disco-infinex]

PerformanceSample type, used to define the return values from the getRecentPerformanceSamples RPC Method incorrectly includes a numNonVoteTransaction field but the RPC call itself returns numNonVoteTransactions (with an "s").

In the core the fields called num_non_vote_transactions but you can see it should be mapped to numNonVoteTransactions, as tested here. The pluralise spelling is also consistent with the other fields (numSlots, numTransactions, etc.).

And, of course, numNonVoteTransactions is what's actually being returned. See for yourself:

curl https://api.devnet.solana.com -X POST -H "Content-Type: application/json" -s \
  -d '{"jsonrpc":"2.0", "id":1,"method": "getRecentPerformanceSamples","params": [1]}' | jq

{
  "jsonrpc": "2.0",
  "result": [
    {
      "numNonVoteTransactions": 850,
      "numSlots": 163,
      "numTransactions": 2792,
      "samplePeriodSecs": 60,
      "slot": 323584907
    }
  ],
  "id": 1
}

The docs are also wrong. I'll PR that too.

[changeset-bot]

🦋 Changeset detected

Latest commit: c64f650

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mcintyre94]

Great spot, thankyou very much!

[disco-infinex]

Looks like this failing test is being fixed in #3201

[mcintyre94]

Perfect, thankyou!

[github-actions]

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.