Use RpcResponseTransformer in PubSubSubscriptionPlan #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Oct 21, 2024
lorisleiva
force-pushed
the
loris/use-rpc-request-in-pub-sub-executor
branch
from
24fbc91 to
ba341d8
Compare
lorisleiva
force-pushed
the
loris/use-rpc-response-transformer-in-pub-sub-executor
branch
from
e3e426b to
fb9b2ed
Compare
lorisleiva
force-pushed
the
loris/use-rpc-request-in-pub-sub-executor
branch
from
ba341d8 to
2dcffdb
Compare
lorisleiva
force-pushed
the
loris/use-rpc-response-transformer-in-pub-sub-executor
branch
from
fb9b2ed to
24a64f5
Compare
lorisleiva
force-pushed
the
loris/use-rpc-request-in-pub-sub-executor
branch
from
2dcffdb to
b640c71
Compare
lorisleiva
force-pushed
the
loris/use-rpc-response-transformer-in-pub-sub-executor
branch
from
24a64f5 to
58f62b4
Compare
This was referenced Oct 21, 2024
| @@ -14,7 +14,7 @@ import { RpcSubscriptionsChannel } from './rpc-subscriptions-channel'; | |||
|
|
|||
| type Config<TNotification> = Readonly<{ | |||
| channel: RpcSubscriptionsChannel<unknown, RpcNotification<TNotification> | RpcResponseData<RpcSubscriptionId>>; | |||
| responseTransformer?: <T>(response: unknown, notificationName: string) => T; | |||
lorisleiva
changed the base branch from
loris/use-rpc-request-in-pub-sub-executor
to
graphite-base/3404
lorisleiva
force-pushed
the
loris/use-rpc-response-transformer-in-pub-sub-executor
branch
from
58f62b4 to
a5545b4
Compare
lorisleiva
deleted the
loris/use-rpc-response-transformer-in-pub-sub-executor
branch
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the definition of a Response Transformer in the RPC Subscriptions architecture from
<T>(response: unknown, notificationName: string) => T;toRpcResponseTransformer.That way, both the RPC and RPC Subscriptions architectures use the same interfaces for transforming requests and responses which means we can refactoring helper method like
getDefaultResponseTransformerForSolanaRpcSubscriptionsin a more composable way (using thepipefunction like we did with default RPC Response Transformer).Note: A changeset for this PR is included in #3407.