Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RpcRequest in PlanExecutor configs #3405

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

lorisleiva
Copy link
Contributor

@lorisleiva lorisleiva commented Oct 21, 2024

This PR replaces the notificationName and params arguments of the RpcSubscriptionsPlanExecutor function by a single request argument of type RpcRequest. This request argument is meant to represent the user intent to request a subscription from the RPC Subscriptions packages.

Note: A changeset for this PR is included in #3407.

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: aa2947b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

Copy link
Contributor Author

lorisleiva commented Oct 23, 2024

Merge activity

  • Oct 23, 4:43 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 23, 4:59 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 23, 5:00 AM EDT: A user merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from loris/use-rpc-response-transformer-in-pub-sub-executor to graphite-base/3405 October 23, 2024 08:55
@lorisleiva lorisleiva changed the base branch from graphite-base/3405 to master October 23, 2024 08:57
@lorisleiva lorisleiva force-pushed the loris/use-rpc-request-in-plan-executor branch from 7c00911 to aa2947b Compare October 23, 2024 08:58
@lorisleiva lorisleiva merged commit cc20b2f into master Oct 23, 2024
7 checks passed
@lorisleiva lorisleiva deleted the loris/use-rpc-request-in-plan-executor branch October 23, 2024 09:00
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants