Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use channel message transformers for JSON serialization #3450

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

lorisleiva
Copy link
Contributor

@lorisleiva lorisleiva commented Oct 25, 2024

This PR uses the new transformChannelInboundMessages and transformChannelOutboundMessages helpers to refactor the existing getRpcSubscriptionsChannelWithJSONSerialization function.

Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 894ea38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@mcintyre94 mcintyre94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

Copy link
Contributor Author

lorisleiva commented Oct 27, 2024

Merge activity

  • Oct 27, 6:03 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 27, 6:13 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 27, 6:13 AM EDT: A user merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from loris/add-channel-transform-messages-helpers to graphite-base/3450 October 27, 2024 10:09
@lorisleiva lorisleiva changed the base branch from graphite-base/3450 to master October 27, 2024 10:11
@lorisleiva lorisleiva force-pushed the loris/use-channel-message-transformers branch from c987f7f to 894ea38 Compare October 27, 2024 10:12
@lorisleiva lorisleiva merged commit cecf20b into master Oct 27, 2024
6 checks passed
@lorisleiva lorisleiva deleted the loris/use-channel-message-transformers branch October 27, 2024 10:13
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants